Devtools: use TextRange in UISourceCode.Message, allow addMessage to take a TextRange

use TextRange in UISourceCode.Message, allow addMessage to take a TextRange

Replacement for https://codereview.chromium.org/1416793005/

BUG=484261
Committed: https://crrev.com/eb1c4e09cd47bd7d5c48d164e47f1f512177f411
Cr-Commit-Position: refs/heads/master@{#361243}

[wes, 2015-11-18 23:22:56]

Description was changed from

==========
use TextRange in UISourceCode.Message, allow addMessage to take a TextRange

Replacement for https://codereview.chromium.org/1416793005/

BUG=484261
==========

to

==========
use TextRange in UISourceCode.Message, allow addMessage to take a TextRange

Replacement for https://codereview.chromium.org/1416793005/

BUG=484261
==========

[wes, 2015-11-18 23:22:56]

wwigham@gmail.com changed reviewers:
+ paulirish@chromium.org, pfeldman@chromium.org

[wes, 2015-11-18 23:23:35]

I've created a new CL with just the TextRange change for your review.

[pfeldman, 2015-11-19 19:18:25]

https://codereview.chromium.org/1456943003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1456943003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:600: *
@param {number|!WebInspector.TextRange} lineNumberOrRange
Lets always use the range - we try to not do instanceof unless absolutely
necessary. You can add a convenience addLineMessage beside.

[wes, 2015-11-19 22:11:25]

https://codereview.chromium.org/1456943003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/1456943003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:600: *
@param {number|!WebInspector.TextRange} lineNumberOrRange
On 2015/11/19 19:18:25, pfeldman wrote:
> Lets always use the range - we try to not do instanceof unless absolutely
> necessary. You can add a convenience addLineMessage beside.

Acknowledged.

[pfeldman, 2015-11-19 22:48:10]

lgtm. btw, when you fix things, you can mark comments as "Done". We typically
use "Ack" to follow up later, etc.

[wes, 2015-11-19 22:48:50]

On 2015/11/19 22:48:10, pfeldman wrote:
> lgtm. btw, when you fix things, you can mark comments as "Done". We typically
> use "Ack" to follow up later, etc.

Ahhh, okay. Didn't know the difference.

[wes, 2015-11-19 22:48:53]

The CQ bit was checked by wwigham@gmail.com

[commit-bot: I haz the power, 2015-11-19 22:50:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456943003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456943003/20001

[commit-bot: I haz the power, 2015-11-19 23:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-19 23:19:13]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)

[wes, 2015-11-23 21:53:23]

The CQ bit was checked by wwigham@gmail.com

[commit-bot: I haz the power, 2015-11-23 21:55:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456943003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456943003/20001

[commit-bot: I haz the power, 2015-11-23 22:23:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-23 22:23:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wes, 2015-11-24 00:49:41]

The CQ bit was checked by wwigham@gmail.com

[wes, 2015-11-24 00:49:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1456943003/#ps40001
(title: "trim whitespace")

[commit-bot: I haz the power, 2015-11-24 00:51:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456943003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456943003/40001

[commit-bot: I haz the power, 2015-11-24 03:26:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-24 03:27:31]

Patchset 3 (id:??) landed as
https://crrev.com/eb1c4e09cd47bd7d5c48d164e47f1f512177f411
Cr-Commit-Position: refs/heads/master@{#361243}