third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js - Issue 1456943003: Devtools: use TextRange in UISourceCode.Message, allow addMessage to take a TextRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

Issue 1456943003: Devtools: use TextRange in UISourceCode.Message, allow addMessage to take a TextRange (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: trim whitespace Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

index edaa92d4703e8a0eddc400d75be2427ccbbdd554..6b3773600bc3bc94a33cce085e987829574ad249 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/PresentationConsoleMessageHelper.js

@@ -178,7 +178,7 @@ WebInspector.PresentationConsoleMessage.prototype = {

{

if (this._uiMessage)

this._uiMessage.remove();

- this._uiMessage = uiLocation.uiSourceCode.addMessage(this._level, this._text, uiLocation.lineNumber, uiLocation.columnNumber);

+ this._uiMessage = uiLocation.uiSourceCode.addLineMessage(this._level, this._text, uiLocation.lineNumber, uiLocation.columnNumber);

dispose: function()

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js » ('j') | no next file with comments »