Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1456863003: Disable failing tests on Mac 10.10 Release (ATI) (Closed)

Created:
5 years, 1 month ago by hcarmona
Modified:
5 years, 1 month ago
Reviewers:
hubbe, miu
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing tests on Mac 10.10 Release (ATI) Failing tests on Mac OS: CastStreamingApiTestWithPixelOutput.EndToEnd TabCaptureApiPixelTest.EndToEndThroughWebRTC TabCaptureApiPixelTest.EndToEndWithoutRemoting BUG=557929 TBR=hubbe@chromium.org, miu@chromium.org Committed: https://crrev.com/872e59f9875efaad8b73b44cf2707c0a57d52244 Cr-Commit-Position: refs/heads/master@{#360460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/extensions/api/cast_streaming/cast_streaming_apitest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
hcarmona
I'm disabling these tests b/c bot is failing. See bug for more details.
5 years, 1 month ago (2015-11-18 22:52:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456863003/1
5 years, 1 month ago (2015-11-18 23:54:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 01:10:57 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/872e59f9875efaad8b73b44cf2707c0a57d52244 Cr-Commit-Position: refs/heads/master@{#360460}
5 years, 1 month ago (2015-11-19 01:11:46 UTC) #7
miu
5 years, 1 month ago (2015-11-19 02:51:07 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1462603003/ by miu@chromium.org.

The reason for reverting is: Tests indicated other CL in blamelist was to blame.

I will both revert the other CL in the blamelist
(https://codereview.chromium.org/1441353003) AND am reverting this CL to confirm
the tests go green again.

See http://crbug.com/557929 for more details..

Powered by Google App Engine
This is Rietveld 408576698