Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1456793002: Revert of Add code to deal with serial device disconnection detection on Windows (Closed)

Created:
5 years, 1 month ago by hcarmona
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add code to deal with serial device disconnection detection on Windows (patchset #14 id:260001 of https://codereview.chromium.org/1439443002/ ) Reason for revert: Reverting because of compile issue on https://build.chromium.org/p/chromium/builders/Win/builds/37540 unresolved external symbol "public: __thiscall device::DeviceInfoQueryWin::DeviceInfoQueryWin(void) Please fix Original issue's description: > Add code to deal with serial device disconnection > detection on Windows. > > This patch added code to deal with serial device > disconnection detection problem on Windows. It gets the > COM port information from the device path and compare > the COM port information with the port information that > serial io handler holds. If they match, cancel read for > that port. > > BUG=361606 > > Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa > Cr-Commit-Position: refs/heads/master@{#360193} TBR=reillyg@chromium.org,grt@chromium.org,thestig@chromium.org,juncai@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=361606 Committed: https://crrev.com/4e9fba01a3d8e3f699dca4fa7c48df08edd5e8b7 Cr-Commit-Position: refs/heads/master@{#360212}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -251 lines) Patch
M device/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M device/core/core.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D device/core/device_info_query_win.h View 1 chunk +0 lines, -49 lines 0 comments Download
D device/core/device_info_query_win.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M device/serial/serial_io_handler.h View 2 chunks +0 lines, -12 lines 0 comments Download
M device/serial/serial_io_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/serial/serial_io_handler_win.h View 3 chunks +0 lines, -8 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 5 chunks +4 lines, -101 lines 0 comments Download
M device/usb/usb_service_impl.cc View 2 chunks +72 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hcarmona
Created Revert of Add code to deal with serial device disconnection detection on Windows
5 years, 1 month ago (2015-11-17 23:50:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456793002/1
5 years, 1 month ago (2015-11-17 23:52:17 UTC) #2
Reilly Grant (use Gerrit)
Charlie, please make sure battor_agent.exe is being built on trybots so breakages like this don't ...
5 years, 1 month ago (2015-11-17 23:58:56 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 23:59:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4e9fba01a3d8e3f699dca4fa7c48df08edd5e8b7 Cr-Commit-Position: refs/heads/master@{#360212}
5 years, 1 month ago (2015-11-18 00:00:24 UTC) #5
charliea (OOO until 10-5)
On 2015/11/18 00:00:24, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
5 years, 1 month ago (2015-11-18 14:30:43 UTC) #6
juncai
5 years, 1 month ago (2015-11-20 18:55:01 UTC) #7
Message was sent while issue was closed.
On 2015/11/18 14:30:43, charliea wrote:
> On 2015/11/18 00:00:24, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/4e9fba01a3d8e3f699dca4fa7c48df08edd5e8b7
> > Cr-Commit-Position: refs/heads/master@{#360212}
> 
> I will - really sorry about this. I thought that the binary was already being
> built on the trybots, but clearly something is wrong where it's not. Looking
> into it now.

Hi Charlie, just wondering if the battor_agent.exe issue is resolved on trybots
so that I can reland my patch? Thanks a lot.

Powered by Google App Engine
This is Rietveld 408576698