Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and suggestion picker
TBR=rjkroege@chromium.org

Committed: https://crrev.com/841bbae802203a51e8a26fb94a7af112bcba7e52
Cr-Commit-Position: refs/heads/master@{#366048}

[oshima, 2015-11-17 23:23:05]

Patchset #4 (id:60001) has been deleted

[oshima, 2015-11-17 23:23:08]

Patchset #3 (id:40001) has been deleted

[oshima, 2015-11-17 23:23:18]

Patchset #1 (id:1) has been deleted

[oshima, 2015-11-17 23:24:01]

Patchset #2 (id:80001) has been deleted

[oshima, 2015-11-17 23:24:10]

Patchset #1 (id:20001) has been deleted

[oshima, 2015-11-17 23:24:59]

Description was changed from

==========
Popup

BUG=

patch from issue 1414603011 at patchset 20001
(http://crrev.com/1414603011#ps20001)
==========

to

==========
Popup

BUG=485650
==========

[oshima, 2015-11-17 23:29:41]

Description was changed from

==========
Popup

BUG=485650
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToScreen and updated Popup code to use
them when computing the anchor rect.
* Introduced scaleFactor parameter to compute the popup size in screen
coordinate. This is only for list picker for now. I'll address other popups in
follow up CLs.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

[oshima, 2015-11-17 23:29:41]

oshima@chromium.org changed reviewers:
+ tkent@chromium.org

[oshima, 2015-11-17 23:31:41]

Hi, can you take a look and let me know what you think. I also want some advise
where and how to write a test for this.

[oshima, 2015-11-17 23:31:47]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 23:36:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/100001

[commit-bot: I haz the power, 2015-11-18 01:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 01:13:18]

Dry run: This issue passed the CQ dry run.

[tkent, 2015-11-18 07:06:38]

tkent@chromium.org changed reviewers:
+ keishi@chromium.org

[tkent, 2015-11-18 07:06:39]

We have a mac-retina layout test bot.  So, adding some unittests should be
enough.

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:512: IntRect
ChromeClientImpl::viewportToScreen(const IntRect& rectInViewport) const
We can't change the behavior of this function.  The result is exposed to web
authors.
e.g.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

We need to introduce another function like viewportToPhysicalScreen().

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/PopupMenuImpl.cpp (right):

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/PopupMenuImpl.cpp:299: addProperty("scaleFactor",
scaleFactor, data);
I agree that we need to pass scale-factor in addition to zoom-factor.

After https://codereview.chromium.org/1454613002/, we should do the followings
for popups:
 - Update anchorRectInScreen to physical pixels
 - Adjust window.screen for scale-factor in pickerCommon.js adjustWindowRect()

[oshima, 2015-11-18 13:03:24]

thanks, can you point me that mac test file?

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/1456753002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:512: IntRect
ChromeClientImpl::viewportToScreen(const IntRect& rectInViewport) const
On 2015/11/18 07:06:39, tkent wrote:
> We can't change the behavior of this function.  The result is exposed to web
> authors.
> e.g.
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> We need to introduce another function like viewportToPhysicalScreen().

Yes, this is to keep the same behavior in zoom-for-dsf mode. This still maps to
DIP, not physical pixels.

[tkent, 2015-11-19 03:27:18]

> can you point me that mac test file?

It seems I was wrong.  mac-retina bot [1] has no pixel results.

testRunner.setBackingScaleFactor() is available in layout tests.  So, we should
add some pixel layout tests.
third_party/WebKit/LayoutTests/fast/hidpi/ contains such hi-dpi tests.

[1]
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20(retina)

[oshima, 2015-12-01 09:50:05]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-01 09:51:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/120001

[oshima, 2015-12-01 10:03:32]

On 2015/11/19 03:27:18, tkent wrote:
> > can you point me that mac test file?
> 
> It seems I was wrong.  mac-retina bot [1] has no pixel results.
> 
> testRunner.setBackingScaleFactor() is available in layout tests.  So, we
should
> add some pixel layout tests.
> third_party/WebKit/LayoutTests/fast/hidpi/ contains such hi-dpi tests.
> 
> [1]
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9%20(retina)

A few more questions:

* Is highdpi test only for mac?
* Looks like there is no chromeos test in blink. Am I correct? (which is fine,
at least for now)
* I can follow the similar pattern as in
https://codereview.chromium.org/1454613002?
 - I looked at https://www.chromium.org/developers/testing/webkit-layout-tests,
but it doesn't say much about how to write tests, or how tests are organized.
   Is there any other doc that explains how to write and/or how the layout tests
work/are organized?

[commit-bot: I haz the power, 2015-12-01 11:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 11:39:47]

Dry run: This issue passed the CQ dry run.

[tkent, 2015-12-02 00:23:30]

> * Is highdpi test only for mac?

I think all platforms support it.

> * Looks like there is no chromeos test in blink. Am I correct? (which is fine,
at least for now)

Right.  We don't have CrOS layout test bots.  We assume CrOS is same as Linux.

> * I can follow the similar pattern as in
https://codereview.chromium.org/1454613002?
>  - I looked at
https://www.chromium.org/developers/testing/webkit-layout-tests, but it doesn't
say much about how to write tests, or how tests are organized.
>    Is there any other doc that explains how to write and/or how the layout
tests work/are organized?

There's no good documentation.  Copying tests in
https://codereview.chromium.org/1454613002 would be a good starting point.

[oshima, 2015-12-03 19:19:38]

Patchset #3 (id:140001) has been deleted

[oshima, 2015-12-03 19:19:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 19:22:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/160001

[commit-bot: I haz the power, 2015-12-03 19:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 19:40:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[oshima, 2015-12-03 19:49:00]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-03 19:50:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/180001

[commit-bot: I haz the power, 2015-12-03 20:09:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 20:09:25]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[oshima, 2015-12-03 20:28:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-12-03 20:28:48]

Patchset #4 (id:180001) has been deleted

[oshima, 2015-12-03 20:28:54]

Patchset #3 (id:160001) has been deleted

[commit-bot: I haz the power, 2015-12-03 20:30:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/200001

[commit-bot: I haz the power, 2015-12-03 21:47:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-03 21:47:47]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-12-04 01:53:10]

Patchset #4 (id:220001) has been deleted

[oshima, 2015-12-05 01:29:28]

Patchset #4 (id:240001) has been deleted

[oshima, 2015-12-08 20:36:02]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-12-08 20:36:25]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToScreen and updated Popup code to use
them when computing the anchor rect.
* Introduced scaleFactor parameter to compute the popup size in screen
coordinate. This is only for list picker for now. I'll address other popups in
follow up CLs.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Introduced scaleFactor parameter to compute the popup size in screen
coordinate. This is only for list picker for now. I'll address other popups in
follow up CLs.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

[commit-bot: I haz the power, 2015-12-08 20:38:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/280001

[oshima, 2015-12-08 20:43:07]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-12-08 20:43:15]

Patchset #4 (id:260001) has been deleted

[oshima, 2015-12-08 20:43:21]

Patchset #3 (id:200001) has been deleted

[commit-bot: I haz the power, 2015-12-08 20:43:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/300001

[oshima, 2015-12-08 21:10:40]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Introduced scaleFactor parameter to compute the popup size in screen
coordinate. This is only for list picker for now. I'll address other popups in
follow up CLs.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

[oshima, 2015-12-08 21:15:10]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

[oshima, 2015-12-08 21:20:35]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=manaul
==========

[oshima, 2015-12-08 21:21:32]

I tried to add a test, but turns out I need to fix test harness first. (filed
crbug.com/567837) May I add a test in a follow up CL?

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/PopupMenuImpl.cpp (right):

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/PopupMenuImpl.cpp:294: IntRect inScreen =
m_chromeClient->viewportToScreen(IntRect(0, 0, 100, 0));
Please let me know if you prefer to add a separate API to get the
viewport->window scale.

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/PopupMenuImpl.cpp:296: addProperty("zoomFactor",
zoom / scaleFactor, data);
Please let me know if you prefer to rename zoomFactor to something else (like
just scaleFactor).

[commit-bot: I haz the power, 2015-12-08 23:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-08 23:15:31]

Dry run: This issue passed the CQ dry run.

[tkent, 2015-12-09 04:35:51]

overall change looks good.

I don't want to accept this without tests.  Let's fix crbug.com/567837.

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/resources/suggestionPicker.js (right):

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/resources/suggestionPicker.js:144: var totalHeight
= ListBorder
Add ';' back.

[oshima, 2015-12-09 06:48:07]

On 2015/12/09 04:35:51, tkent wrote:
> overall change looks good.
> 
> I don't want to accept this without tests.  Let's fix crbug.com/567837.

Sure. Can you comment on the bug? I probably can figure out a solution myself,
but it'd be better if you or someone who is more familiar with blink's test
framework can suggest more better, concrete approach.

> 
>
https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/web/resources/suggestionPicker.js (right):
> 
>
https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
> third_party/WebKit/Source/web/resources/suggestionPicker.js:144: var
totalHeight
> = ListBorder
> Add ';' back.

[oshima, 2015-12-16 23:10:54]

Patchset #7 (id:360001) has been deleted

[oshima, 2015-12-16 23:11:05]

Patchset #6 (id:340001) has been deleted

[oshima, 2015-12-16 23:12:02]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 23:13:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/380001

[commit-bot: I haz the power, 2015-12-16 23:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 23:43:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[oshima, 2015-12-16 23:57:45]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 23:58:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/400001

[oshima, 2015-12-17 01:27:40]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 02:35:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/420001

[commit-bot: I haz the power, 2015-12-17 03:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 03:09:19]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[oshima, 2015-12-17 03:35:22]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 03:37:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/440001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/440001

[oshima, 2015-12-17 05:01:28]

Added tests. PTAL.

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
File third_party/WebKit/Source/web/resources/suggestionPicker.js (right):

https://codereview.chromium.org/1456753002/diff/300001/third_party/WebKit/Sou...
third_party/WebKit/Source/web/resources/suggestionPicker.js:144: var totalHeight
= ListBorder
On 2015/12/09 04:35:51, tkent wrote:
> Add ';' back.

Done.

[commit-bot: I haz the power, 2015-12-17 05:12:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 05:12:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2015-12-17 08:52:43]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 08:53:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/440001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/440001

[commit-bot: I haz the power, 2015-12-17 10:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 10:14:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2015-12-17 16:42:50]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 16:43:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/440001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/440001

[commit-bot: I haz the power, 2015-12-17 18:07:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 18:07:31]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2015-12-17 19:40:36]

Patchset #10 (id:460001) has been deleted

[tkent, 2015-12-18 00:14:36]

lgtm.

should mark popup-menu-appearance-dsf2.html [ NeedsRebaseline] on Mac.

[oshima, 2015-12-18 02:10:44]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-12-18 02:11:31]

oshima@chromium.org changed reviewers:
+ mkwst@chromium.org

[oshima, 2015-12-18 02:11:31]

mkwst@ -> content/shell/renderer/layout/test owner

[commit-bot: I haz the power, 2015-12-18 02:11:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/480001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/480001

[commit-bot: I haz the power, 2015-12-18 03:26:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 03:26:23]

Dry run: This issue passed the CQ dry run.

[Mike West, 2015-12-18 06:59:40]

components/test_runner and c/s/r/layout_test LGTM.

[oshima, 2015-12-18 08:06:47]

oshima@chromium.org changed reviewers:
+ rjkroege@chromium.org

[oshima, 2015-12-18 08:06:47]

TBR'ing rjkroege@ for trivial changes in components/html_viewer/

[oshima, 2015-12-18 08:07:43]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=manaul
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and
suggestion picker
TBR=rjkroege@chromium.org
==========

[oshima, 2015-12-18 08:07:54]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-12-18 08:07:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1456753002/#ps480001
(title: "update TestExpectations")

[commit-bot: I haz the power, 2015-12-18 08:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1456753002/480001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1456753002/480001

[commit-bot: I haz the power, 2015-12-18 08:14:36]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and
suggestion picker
TBR=rjkroege@chromium.org
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and
suggestion picker
TBR=rjkroege@chromium.org
==========

[commit-bot: I haz the power, 2015-12-18 08:14:38]

Committed patchset #10 (id:480001)

[commit-bot: I haz the power, 2015-12-18 08:15:25]

Description was changed from

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and
suggestion picker
TBR=rjkroege@chromium.org
==========

to

==========
Compute the popup location/size correctly when use-zoom-for-dsf is enabled.

* Add WebWidgetClient::convertViewportToWindow and updated Popup code to use
them when computing the anchor rect.
* Apply scale parameter to zoomFactor used to scale the popup in js.
* Changed picker JS code to use screen coordinates always rather than mix of
viewport and screen.
* Refactored RenderViewImpl/RenderWidget so that the device scale factor gets
set in content rather than from Blink.

BUG=485650
TEST=-dsf2.html, -dsf2-with-zoom.html added for popup-menu, calendar-picker and
suggestion picker
TBR=rjkroege@chromium.org

Committed: https://crrev.com/841bbae802203a51e8a26fb94a7af112bcba7e52
Cr-Commit-Position: refs/heads/master@{#366048}
==========

[commit-bot: I haz the power, 2015-12-18 08:15:26]

Patchset 10 (id:??) landed as
https://crrev.com/841bbae802203a51e8a26fb94a7af112bcba7e52
Cr-Commit-Position: refs/heads/master@{#366048}