Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 145663012: Remove the layout timer (Closed)

Created:
6 years, 10 months ago by abarth-chromium
Modified:
6 years, 10 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews
Visibility:
Public.

Description

Remove the layout timer As discussed on blink-dev, we want to remove the layout timer in order to better synchronize work with the compositor. Prior to this CL, we'd trigger layout at arbitrary times, which meant we could end up doing layout multiple times per frame unnecessarily. BUG=340357 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166415 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166545

Patch Set 1 #

Patch Set 2 : Add workaround for plugins #

Total comments: 1

Patch Set 3 : updateLayout #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M Source/core/dom/Document.h View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 7 chunks +12 lines, -15 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
abarth-chromium
This CL is ready for review. There are a couple of other CLs that need ...
6 years, 10 months ago (2014-02-04 00:57:36 UTC) #1
ojan
lgtm woot!
6 years, 10 months ago (2014-02-04 01:03:06 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-04 05:49:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145663012/1
6 years, 10 months ago (2014-02-04 05:49:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 09:04:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10739
6 years, 10 months ago (2014-02-04 09:04:09 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-04 15:41:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145663012/1
6 years, 10 months ago (2014-02-04 15:41:19 UTC) #8
commit-bot: I haz the power
Change committed as 166415
6 years, 10 months ago (2014-02-04 16:40:20 UTC) #9
fmalita_google_do_not_use
On 2014/02/04 16:40:20, I haz the power (commit-bot) wrote: > Change committed as 166415 Looks ...
6 years, 10 months ago (2014-02-04 20:25:58 UTC) #10
fmalita_google_do_not_use
On 2014/02/04 20:25:58, fmalita wrote: > On 2014/02/04 16:40:20, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-02-04 20:41:37 UTC) #11
f(malita)
A revert of this CL has been created in https://codereview.chromium.org/154273002/ by fmalita@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-04 20:43:07 UTC) #12
abarth-chromium
SiteIsolationPolicyBrowserTest.CrossSiteDocumentBlockingForDifferentTargets was failing because we never finished loading the page because the page contained plugins. ...
6 years, 10 months ago (2014-02-04 23:06:10 UTC) #13
abarth-chromium
https://codereview.chromium.org/145663012/diff/240001/Source/core/dom/Document.cpp File Source/core/dom/Document.cpp (right): https://codereview.chromium.org/145663012/diff/240001/Source/core/dom/Document.cpp#newcode4937 Source/core/dom/Document.cpp:4937: } Ojan, would you be willing to review this ...
6 years, 10 months ago (2014-02-04 23:26:37 UTC) #14
fmalita_google_do_not_use
On 2014/02/04 23:26:37, abarth wrote: > https://codereview.chromium.org/145663012/diff/240001/Source/core/dom/Document.cpp > File Source/core/dom/Document.cpp (right): > > https://codereview.chromium.org/145663012/diff/240001/Source/core/dom/Document.cpp#newcode4937 > ...
6 years, 10 months ago (2014-02-05 00:20:25 UTC) #15
ojan
lgtm
6 years, 10 months ago (2014-02-05 01:51:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145663012/240001
6 years, 10 months ago (2014-02-05 01:52:06 UTC) #17
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 10 months ago (2014-02-05 05:31:09 UTC) #18
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-05 19:53:52 UTC) #19
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 10 months ago (2014-02-05 19:54:01 UTC) #20
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 10 months ago (2014-02-05 19:57:38 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/145663012/440001
6 years, 10 months ago (2014-02-05 19:57:59 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 21:56:50 UTC) #23
Message was sent while issue was closed.
Change committed as 166545

Powered by Google App Engine
This is Rietveld 408576698