Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1456463002: [WebSocket] Remove release assertions that are no longer needed. (Closed)

Created:
5 years, 1 month ago by yhirano
Modified:
5 years ago
CC:
chromium-reviews, blink-reviews, yhirano+watch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebSocket] Remove release assertions that are no longer needed. [1] and [2] placed release assertions to investigate a crash bug and provide a workaround solution. Now the right fix has been landed and we can remove them. 1: https://crrev.com/4b823461db8e2bc8faf5438be4cc30f6a9401aef 2: https://crrev.com/a6af78bd57595484765d2a3ca18f38fa135be796 BUG=550632 Committed: https://crrev.com/c9feab14e31c6e5bbaaef2461529f7b20df47ac6 Cr-Commit-Position: refs/heads/master@{#361320}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
yhirano
5 years, 1 month ago (2015-11-19 08:43:43 UTC) #2
haraken
LGTM
5 years ago (2015-11-24 06:26:14 UTC) #3
sof
(the prefinalizers added here didn't serve a purpose, as they weren't registered.. )
5 years ago (2015-11-24 07:29:17 UTC) #5
tyoshino (SeeGerritForStatus)
lgtm
5 years ago (2015-11-24 08:33:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456463002/1
5 years ago (2015-11-24 10:06:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 11:55:37 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 11:56:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9feab14e31c6e5bbaaef2461529f7b20df47ac6
Cr-Commit-Position: refs/heads/master@{#361320}

Powered by Google App Engine
This is Rietveld 408576698