third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h - Issue 1456463002: [WebSocket] Remove release assertions that are no longer needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

Issue 1456463002: [WebSocket] Remove release assertions that are no longer needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

index 62d8fe9e174b5feb89b75bcc870d73b9672db1e6..5f1bb6c745d0d5dcf5d97e0d23a968f16cabcb21 100644

--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h

@@ -62,7 +62,6 @@ class WebSocketHandshakeResponseInfo;

// DOMWindow (i.e. works in the main thread).

class MODULES_EXPORT DocumentWebSocketChannel final : public WebSocketChannel, public WebSocketHandleClient, public ContextLifecycleObserver {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(DocumentWebSocketChannel);

- USING_PRE_FINALIZER(DocumentWebSocketChannel, handleShouldBeDisconnected);

public:

// You can specify the source file and the line number information

// explicitly by passing the last parameter.

@@ -134,7 +133,6 @@ private:

void abortAsyncOperations();

void handleDidClose(bool wasClean, unsigned short code, const String& reason);

Document* document();

- void handleShouldBeDisconnected();

// WebSocketHandleClient functions.

void didConnect(WebSocketHandle*, const WebString& selectedProtocol, const WebString& extensions) override;