Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1456053002: Add Nullity check for instant service (Closed)

Created:
5 years, 1 month ago by bshe
Modified:
5 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Nullity check for instant service This code path is now also used by Android. And it may return null. So add nullity check to avoid crash. BUG=557285 Committed: https://crrev.com/b4a8cf7a82ae168ea915d44f5997a7e756eca6c6 Cr-Commit-Position: refs/heads/master@{#360433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
bshe
Hi Scott. Do you mind to take a look at this simple CL? Thanks!
5 years, 1 month ago (2015-11-18 21:38:13 UTC) #2
sky
LGTM
5 years, 1 month ago (2015-11-18 22:14:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456053002/1
5 years, 1 month ago (2015-11-18 22:19:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 22:42:52 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 22:43:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4a8cf7a82ae168ea915d44f5997a7e756eca6c6
Cr-Commit-Position: refs/heads/master@{#360433}

Powered by Google App Engine
This is Rietveld 408576698