Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 145603002: Eliminate large chunks of nearly duplicated code for table-row-group border calculation. (Closed)

Created:
6 years, 11 months ago by mstensho (USE GERRIT)
Modified:
6 years, 11 months ago
Reviewers:
ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, a.suchit
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Eliminate large chunks of nearly duplicated code for table-row-group border calculation. calcOuterBorderBefore() and calcOuterBorderAfter() were almost identical. So were calcOuterBorderStart() and calcOuterBorderEnd(). Merge them into calcBlockDirectionOuterBorder() and calcInlineDirectionOuterBorder(). This is just code cleanup; no behavior changes intended. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165746

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address code review issue raised together with lgtm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -117 lines) Patch
M Source/core/rendering/RenderTableSection.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 1 6 chunks +26 lines, -113 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mstensho (USE GERRIT)
6 years, 11 months ago (2014-01-23 11:53:04 UTC) #1
ojan
lgtm Please split up the function before committing. No need for another followup review unless ...
6 years, 11 months ago (2014-01-24 01:35:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/145603002/60001
6 years, 11 months ago (2014-01-24 10:31:54 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 13:48:52 UTC) #4
Message was sent while issue was closed.
Change committed as 165746

Powered by Google App Engine
This is Rietveld 408576698