Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: Source/core/rendering/RenderTableSection.h

Issue 145603002: Eliminate large chunks of nearly duplicated code for table-row-group border calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Address code review issue raised together with lgtm Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after
167 { 167 {
168 CellStruct& c = m_grid[row].row[col]; 168 CellStruct& c = m_grid[row].row[col];
169 return c.primaryCell(); 169 return c.primaryCell();
170 } 170 }
171 171
172 RenderTableRow* rowRendererAt(unsigned row) const { return m_grid[row].rowRe nderer; } 172 RenderTableRow* rowRendererAt(unsigned row) const { return m_grid[row].rowRe nderer; }
173 173
174 void appendColumn(unsigned pos); 174 void appendColumn(unsigned pos);
175 void splitColumn(unsigned pos, unsigned first); 175 void splitColumn(unsigned pos, unsigned first);
176 176
177 int calcOuterBorderBefore() const; 177 enum BlockBorderSide { BorderBefore, BorderAfter };
178 int calcOuterBorderAfter() const; 178 int calcBlockDirectionOuterBorder(BlockBorderSide) const;
179 int calcOuterBorderStart() const; 179 enum InlineBorderSide { BorderStart, BorderEnd };
180 int calcOuterBorderEnd() const; 180 int calcInlineDirectionOuterBorder(InlineBorderSide) const;
181 void recalcOuterBorder(); 181 void recalcOuterBorder();
182 182
183 int outerBorderBefore() const { return m_outerBorderBefore; } 183 int outerBorderBefore() const { return m_outerBorderBefore; }
184 int outerBorderAfter() const { return m_outerBorderAfter; } 184 int outerBorderAfter() const { return m_outerBorderAfter; }
185 int outerBorderStart() const { return m_outerBorderStart; } 185 int outerBorderStart() const { return m_outerBorderStart; }
186 int outerBorderEnd() const { return m_outerBorderEnd; } 186 int outerBorderEnd() const { return m_outerBorderEnd; }
187 187
188 unsigned numRows() const { return m_grid.size(); } 188 unsigned numRows() const { return m_grid.size(); }
189 unsigned numColumns() const; 189 unsigned numColumns() const;
190 void recalcCells(); 190 void recalcCells();
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
306 // This map holds the collapsed border values for cells with collapsed borde rs. 306 // This map holds the collapsed border values for cells with collapsed borde rs.
307 // It is held at RenderTableSection level to spare memory consumption by tab le cells. 307 // It is held at RenderTableSection level to spare memory consumption by tab le cells.
308 HashMap<pair<const RenderTableCell*, int>, CollapsedBorderValue > m_cellsCol lapsedBorders; 308 HashMap<pair<const RenderTableCell*, int>, CollapsedBorderValue > m_cellsCol lapsedBorders;
309 }; 309 };
310 310
311 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTableSection, isTableSection()); 311 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTableSection, isTableSection());
312 312
313 } // namespace WebCore 313 } // namespace WebCore
314 314
315 #endif // RenderTableSection_h 315 #endif // RenderTableSection_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698