Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1455983002: [turbofan] Implemented the ChangeFloat64ToInt64 TurboFan operator. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implemented the ChangeFloat64ToInt64 TurboFan operator. The ChangeFloat64ToInt64 operator changes the representation of a float64 input value to int64 if the input value can be represented exactly on int64. Otherwise the result is currently undefined. R=titzer@chromium.org Committed: https://crrev.com/ed570fac4479dd6392e3333c2fe4442d431ea646 Cr-Commit-Position: refs/heads/master@{#32102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -12 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +14 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ahaas
5 years, 1 month ago (2015-11-18 13:27:48 UTC) #1
titzer
On 2015/11/18 13:27:48, ahaas wrote: lgtm
5 years, 1 month ago (2015-11-18 16:50:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455983002/1
5 years, 1 month ago (2015-11-19 08:25:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 08:26:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed570fac4479dd6392e3333c2fe4442d431ea646 Cr-Commit-Position: refs/heads/master@{#32102}
5 years, 1 month ago (2015-11-19 08:27:39 UTC) #6
Benedikt Meurer
I think we shouldn't use "Change" as name for operators that do not preserve the ...
5 years, 1 month ago (2015-11-19 11:28:18 UTC) #8
titzer
On 2015/11/19 11:28:18, Benedikt Meurer wrote: > I think we shouldn't use "Change" as name ...
5 years, 1 month ago (2015-11-19 13:16:13 UTC) #9
ahaas
5 years, 1 month ago (2015-11-19 13:20:47 UTC) #10
Message was sent while issue was closed.
I will rename the operator in a separate CL to TruncateFloat64ToInt64.

Powered by Google App Engine
This is Rietveld 408576698