[turbofan] Fix CFI failures with Operator1 class.

[turbofan] Fix CFI failures with Operator1 class.

This ensures the class in question specifies the correct equality and
hashing function when instantiated. Note that this introduces two new
structs (i.e. OpEqualTo and OpHash) which can be used for defaults
within OpParameter as well.

R=titzer@chromium.org,bmeurer@chromium.org
TEST=cctest/test-operator

Committed: https://crrev.com/1582f37cd83f3d05e5b1d6ff2690e65a18c3656a
Cr-Commit-Position: refs/heads/master@{#32080}

[Michael Starzinger, 2015-11-18 12:38:00]

Description was changed from

==========
[turbofan] Fix CFI failur in test-operator test.

This ensures the test in question speficies the correct equality and
hashing function when instantiating Operator1 classes. Note that this
also add guarding template specializations for Operator1 that prevent
such bogus instantiations in the future.

R=titzer@chromium.org,bmeurer@chromium.org
TEST=cctest/test-operator
==========

to

==========
[turbofan] Fix CFI failure in test-operator test.

This ensures the test in question specifies the correct equality and
hashing function when instantiating Operator1 classes. Note that this
also add guarding template specializations for Operator1 that prevent
such bogus instantiations in the future.

R=titzer@chromium.org,bmeurer@chromium.org
TEST=cctest/test-operator
==========

[Michael Starzinger, 2015-11-18 13:06:51]

Alternative approach as discussed offline. Kudos to Ben for the idea! PTAL.

[titzer, 2015-11-18 13:08:44]

lgtm you be blowin me mind

[Benedikt Meurer, 2015-11-18 13:10:34]

It was such a great idea to put this reinterpret_cast there combined with the
awesome Operator1 template... *closing eyes* LGTM

[Michael Starzinger, 2015-11-18 13:20:22]

Description was changed from

==========
[turbofan] Fix CFI failure in test-operator test.

This ensures the test in question specifies the correct equality and
hashing function when instantiating Operator1 classes. Note that this
also add guarding template specializations for Operator1 that prevent
such bogus instantiations in the future.

R=titzer@chromium.org,bmeurer@chromium.org
TEST=cctest/test-operator
==========

to

==========
[turbofan] Fix CFI failures with Operator1 class.

This ensures the class in question specifies the correct equality and
hashing function when instantiated. Note that this introduces two new
structs (i.e. OpEqualTo and OpHash) which can be used for defaults
within OpParameter as well.

R=titzer@chromium.org,bmeurer@chromium.org
TEST=cctest/test-operator
==========

[Michael Starzinger, 2015-11-18 13:21:25]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-11-18 13:21:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455913003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455913003/20001

[commit-bot: I haz the power, 2015-11-18 13:48:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-18 13:48:47]

Patchset 2 (id:??) landed as
https://crrev.com/1582f37cd83f3d05e5b1d6ff2690e65a18c3656a
Cr-Commit-Position: refs/heads/master@{#32080}