Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1453973004: [turbofan] Fix CFI failures in BytecodeGraphBuilder unit test. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
oth, mythria
CC:
v8-reviews_googlegroups.com, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_fix-operator1-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix CFI failures in BytecodeGraphBuilder unit test. This fixes undefined behavior with the OpParameter helper in some of our node matchers. There was a constness mismatch of the template parameter. R=oth@chromium.org,mythria@chromium.org Committed: https://crrev.com/8a57c81b3a25b58ed6547e624e72f67ec0cb46cf Cr-Commit-Position: refs/heads/master@{#32087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M test/unittests/compiler/node-test-utils.cc View 3 chunks +18 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (1 generated)
Michael Starzinger
For context, this CL is to fix the following UBSan failures on the waterfall with ...
5 years, 1 month ago (2015-11-18 13:43:59 UTC) #1
Michael Starzinger
The code review tool is garbling up my link to the waterfall. Here is a ...
5 years, 1 month ago (2015-11-18 13:46:48 UTC) #2
oth
Thanks Michi, hadn't realized this. lgtm.
5 years, 1 month ago (2015-11-18 14:00:29 UTC) #3
mythria
lgtm Thanks,
5 years, 1 month ago (2015-11-18 14:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453973004/1
5 years, 1 month ago (2015-11-18 14:14:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 14:15:45 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 14:16:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a57c81b3a25b58ed6547e624e72f67ec0cb46cf
Cr-Commit-Position: refs/heads/master@{#32087}

Powered by Google App Engine
This is Rietveld 408576698