MIPS: stub fast api calls

MIPS: stub fast api calls

Port r18847 (c920fc50)

BUG=
R=plind44@gmail.com

Committed: https://code.google.com/p/v8/source/detail?r=18863

[palfia, 2014-01-27 23:54:02]

PTAL.

[Paul Lind, 2014-01-28 00:21:13]

Take a look at the push comments, and see if you agree we can combine them.
Otherwise, LGTM.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5707: //  -- esp[argc * 4]       : receiver
nit: these should be sp, not esp.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5744: 
Suggest you combine push ops where possible. It saves instructions on mips (not
on arm). Please try to tidy up the nice commenting, so that it still makes
sense.

You can probably do Push(context, callee, call_data);
and update context reg afterwards.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5752: __ push(scratch);
__ Push(scratch, scratch);

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5758: __ push(holder);
__ Push(scratch, holder);

[palfia, 2014-01-28 01:15:14]

Thanks for the review and comments, it's much cleaner now!

I've uploaded the new patch.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5707: //  -- esp[argc * 4]       : receiver
On 2014/01/28 00:21:13, Paul Lind wrote:
> nit: these should be sp, not esp.

Done.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5744: 
On 2014/01/28 00:21:13, Paul Lind wrote:
> Suggest you combine push ops where possible. It saves instructions on mips
(not
> on arm). Please try to tidy up the nice commenting, so that it still makes
> sense.
> 
> You can probably do Push(context, callee, call_data);
> and update context reg afterwards.

Done.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5752: __ push(scratch);
On 2014/01/28 00:21:13, Paul Lind wrote:
> __ Push(scratch, scratch);

Done.

https://codereview.chromium.org/145583012/diff/1/src/mips/code-stubs-mips.cc#...
src/mips/code-stubs-mips.cc:5758: __ push(holder);
On 2014/01/28 00:21:13, Paul Lind wrote:
> __ Push(scratch, holder);

Done.

[palfia, 2014-01-28 01:35:31]

Committed patchset #2 manually as r18863 (tree was closed).