Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 145583005: [SVG] Remove existing event listeners when eventBase conditions are cleared (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index cb08bd6bbbf467d531b0aa159e00a935a3284104..86ade8d0d271629fd81b27f4e30284e03fcbcfcb 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -506,6 +506,7 @@ void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin
if (name == SVGNames::beginAttr) {
if (!m_conditions.isEmpty()) {
disconnectSyncBaseConditions();
+ disconnectEventBaseConditions();
m_conditions.clear();
f(malita) 2014/01/27 15:35:33 Looks like m_conditions.clear() is always accompan
pavane 2014/01/27 17:01:19 Done.
parseBeginOrEnd(fastGetAttribute(SVGNames::endAttr), End);
}
@@ -515,6 +516,7 @@ void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin
} else if (name == SVGNames::endAttr) {
if (!m_conditions.isEmpty()) {
disconnectSyncBaseConditions();
+ disconnectEventBaseConditions();
m_conditions.clear();
parseBeginOrEnd(fastGetAttribute(SVGNames::beginAttr), Begin);
}

Powered by Google App Engine
This is Rietveld 408576698