Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 145583005: [SVG] Remove existing event listeners when eventBase conditions are cleared (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 supportedAttributes.add(XLinkNames::hrefAttr); 499 supportedAttributes.add(XLinkNames::hrefAttr);
500 } 500 }
501 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 501 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
502 } 502 }
503 503
504 void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value) 504 void SVGSMILElement::parseAttribute(const QualifiedName& name, const AtomicStrin g& value)
505 { 505 {
506 if (name == SVGNames::beginAttr) { 506 if (name == SVGNames::beginAttr) {
507 if (!m_conditions.isEmpty()) { 507 if (!m_conditions.isEmpty()) {
508 disconnectSyncBaseConditions(); 508 disconnectSyncBaseConditions();
509 disconnectEventBaseConditions();
509 m_conditions.clear(); 510 m_conditions.clear();
f(malita) 2014/01/27 15:35:33 Looks like m_conditions.clear() is always accompan
pavane 2014/01/27 17:01:19 Done.
510 parseBeginOrEnd(fastGetAttribute(SVGNames::endAttr), End); 511 parseBeginOrEnd(fastGetAttribute(SVGNames::endAttr), End);
511 } 512 }
512 parseBeginOrEnd(value.string(), Begin); 513 parseBeginOrEnd(value.string(), Begin);
513 if (inDocument()) 514 if (inDocument())
514 connectSyncBaseConditions(); 515 connectSyncBaseConditions();
515 } else if (name == SVGNames::endAttr) { 516 } else if (name == SVGNames::endAttr) {
516 if (!m_conditions.isEmpty()) { 517 if (!m_conditions.isEmpty()) {
517 disconnectSyncBaseConditions(); 518 disconnectSyncBaseConditions();
519 disconnectEventBaseConditions();
518 m_conditions.clear(); 520 m_conditions.clear();
519 parseBeginOrEnd(fastGetAttribute(SVGNames::beginAttr), Begin); 521 parseBeginOrEnd(fastGetAttribute(SVGNames::beginAttr), Begin);
520 } 522 }
521 parseBeginOrEnd(value.string(), End); 523 parseBeginOrEnd(value.string(), End);
522 if (inDocument()) 524 if (inDocument())
523 connectSyncBaseConditions(); 525 connectSyncBaseConditions();
524 } else if (name == SVGNames::onbeginAttr) { 526 } else if (name == SVGNames::onbeginAttr) {
525 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value)); 527 setAttributeEventListener(EventTypeNames::beginEvent, createAttributeEve ntListener(this, name, value));
526 } else if (name == SVGNames::onendAttr) { 528 } else if (name == SVGNames::onendAttr) {
527 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value)); 529 setAttributeEventListener(EventTypeNames::endEvent, createAttributeEvent Listener(this, name, value));
(...skipping 777 matching lines...) Expand 10 before | Expand all | Expand 10 after
1305 if (eventType == "repeatn") { 1307 if (eventType == "repeatn") {
1306 unsigned repeatEventCount = m_repeatEventCountList.first(); 1308 unsigned repeatEventCount = m_repeatEventCountList.first();
1307 m_repeatEventCountList.remove(0); 1309 m_repeatEventCountList.remove(0);
1308 dispatchEvent(RepeatEvent::create(eventType, repeatEventCount)); 1310 dispatchEvent(RepeatEvent::create(eventType, repeatEventCount));
1309 } else { 1311 } else {
1310 dispatchEvent(Event::create(eventType)); 1312 dispatchEvent(Event::create(eventType));
1311 } 1313 }
1312 } 1314 }
1313 1315
1314 } 1316 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698