Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: runtime/vm/flow_graph_compiler_mips.cc

Issue 14556002: Uses slt and sltu for signed vs. unsigned comparison by the MIPS assembler. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_mips.cc
===================================================================
--- runtime/vm/flow_graph_compiler_mips.cc (revision 22132)
+++ runtime/vm/flow_graph_compiler_mips.cc (working copy)
@@ -601,10 +601,12 @@
__ lw(T2, FieldAddress(S4, ArgumentsDescriptor::positional_count_offset()));
// Check that min_num_pos_args <= num_pos_args.
Label wrong_num_arguments;
- __ BranchLess(T2, Smi::RawValue(min_num_pos_args), &wrong_num_arguments);
+ __ BranchSignedLess(T2, Smi::RawValue(min_num_pos_args),
+ &wrong_num_arguments);
// Check that num_pos_args <= max_num_pos_args.
- __ BranchGreater(T2, Smi::RawValue(max_num_pos_args), &wrong_num_arguments);
+ __ BranchSignedGreater(T2, Smi::RawValue(max_num_pos_args),
+ &wrong_num_arguments);
// Copy positional arguments.
// Argument i passed at fp[kLastParamSlotIndex + num_args - 1 - i] is copied
@@ -724,7 +726,7 @@
// arguments have been passed, where k is param_pos, the position of this
// optional parameter in the formal parameter list.
const int param_pos = num_fixed_params + i;
- __ BranchGreater(T2, param_pos, &next_parameter);
+ __ BranchSignedGreater(T2, param_pos, &next_parameter);
// Load T3 with default argument.
const Object& value = Object::ZoneHandle(
parsed_function().default_parameter_values().At(i));
@@ -885,7 +887,8 @@
// Skip Branch if T1 is less than the threshold.
Label dont_branch;
- __ BranchLess(T1, FLAG_optimization_counter_threshold, &dont_branch);
+ __ BranchSignedLess(T1, FLAG_optimization_counter_threshold,
+ &dont_branch);
ASSERT(function_reg == T0);
__ Branch(&StubCode::OptimizeFunctionLabel());

Powered by Google App Engine
This is Rietveld 408576698