Pass current script context to InspectorWrapper::unwrap

Pass current script context to InspectorWrapper::unwrap

Also make sure, we're always in the script context when invoking unwrap
(as opposed to the debugger context)

BUG=none
R=haraken@chromium.org

Committed: https://crrev.com/5a3367a795a0fe9f2ca90da911dab5ed54e55e5a
Cr-Commit-Position: refs/heads/master@{#360546}

[jochen (gone - plz use gerrit), 2015-11-17 13:24:28]

I've split this out into a separate CL so
https://codereview.chromium.org/1419313003 doesn't get too big

[haraken, 2015-11-17 14:03:21]

LGTM

[yurys, 2015-11-17 17:39:11]

yurys@chromium.org changed reviewers:
+ yurys@chromium.org

[yurys, 2015-11-17 17:39:12]

https://codereview.chromium.org/1455583002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp (right):

https://codereview.chromium.org/1455583002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp:53: void*
InspectorWrapperBase::unwrap(v8::Local<v8::Context> context,
v8::Local<v8::Object> object, const char* name)
Can you just get CreationContext from the object parameter instead?

[jochen (gone - plz use gerrit), 2015-11-18 12:29:44]

ptal

[yurys, 2015-11-18 18:35:00]

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1113: chain
= AsyncCallChain::create(debugger().isPaused() ? debugger().pausedContext() :
m_isolate->GetCurrentContext(), adoptRef(new AsyncCallStack(description,
callFrames)), m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
Just m_isolate->GetCurrentContext() should work for the case when the debugger
is not paused or am I missing something?

[jochen (gone - plz use gerrit), 2015-11-18 19:02:04]

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1113: chain
= AsyncCallChain::create(debugger().isPaused() ? debugger().pausedContext() :
m_isolate->GetCurrentContext(), adoptRef(new AsyncCallStack(description,
callFrames)), m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
On 2015/11/18 at 18:35:00, yurys wrote:
> Just m_isolate->GetCurrentContext() should work for the case when the debugger
is not paused or am I missing something?

right, but for the cases where it's paused, we're in the debugger context, so I
need to use pausedContext instead

[yurys, 2015-11-18 19:11:24]

lgtm

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):

https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1113: chain
= AsyncCallChain::create(debugger().isPaused() ? debugger().pausedContext() :
m_isolate->GetCurrentContext(), adoptRef(new AsyncCallStack(description,
callFrames)), m_currentAsyncCallChain.get(), m_maxAsyncCallStackDepth);
On 2015/11/18 19:02:04, jochen wrote:
> On 2015/11/18 at 18:35:00, yurys wrote:
> > Just m_isolate->GetCurrentContext() should work for the case when the
debugger
> is not paused or am I missing something?
> 
> right, but for the cases where it's paused, we're in the debugger context, so
I
> need to use pausedContext instead

This method should never be called when current context is the debugger context.
But we can leave this to be on the safe side. We should probably add an assert
that current context is not the debugger context.

[jochen (gone - plz use gerrit), 2015-11-18 19:39:28]

On 2015/11/18 at 19:11:24, yurys wrote:
> lgtm
> 
>
https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp
(right):
> 
>
https://codereview.chromium.org/1455583002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp:1113:
chain = AsyncCallChain::create(debugger().isPaused() ?
debugger().pausedContext() : m_isolate->GetCurrentContext(), adoptRef(new
AsyncCallStack(description, callFrames)), m_currentAsyncCallChain.get(),
m_maxAsyncCallStackDepth);
> On 2015/11/18 19:02:04, jochen wrote:
> > On 2015/11/18 at 18:35:00, yurys wrote:
> > > Just m_isolate->GetCurrentContext() should work for the case when the
debugger
> > is not paused or am I missing something?
> > 
> > right, but for the cases where it's paused, we're in the debugger context,
so I
> > need to use pausedContext instead
> 
> This method should never be called when current context is the debugger
context. But we can leave this to be on the safe side. We should probably add an
assert that current context is not the debugger context.

hum, it didn't work without this. will post a callstack tomorrow where this is
called with the debugger context (or maybe without context?)

[jochen (gone - plz use gerrit), 2015-11-18 20:36:17]

actually, it's empty - this call site:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
puts the context to use in the paused context instead of just entering it - no
idea why

[jochen (gone - plz use gerrit), 2015-11-19 07:55:57]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-19 07:55:57]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1455583002/#ps20001
(title: "updates")

[commit-bot: I haz the power, 2015-11-19 07:56:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1455583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1455583002/20001

[commit-bot: I haz the power, 2015-11-19 10:35:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-19 10:37:06]

Patchset 2 (id:??) landed as
https://crrev.com/5a3367a795a0fe9f2ca90da911dab5ed54e55e5a
Cr-Commit-Position: refs/heads/master@{#360546}