Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h

Issue 1455583002: Pass current script context to InspectorWrapper::unwrap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h b/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h
index 6a9cb96653ea6474cfd79694ee9c81bfb07ea125..6ca9792bcffa283372f60c8af1cdb5de1c663a9b 100644
--- a/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h
+++ b/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h
@@ -30,7 +30,7 @@ public:
protected:
static v8::Local<v8::Object> createWrapper(v8::Local<v8::FunctionTemplate>, v8::Local<v8::Context>);
- static void* unwrap(v8::Local<v8::Object>, const char* name);
+ static void* unwrap(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name);
static v8::Local<v8::String> v8InternalizedString(v8::Isolate*, const char* name);
};
@@ -89,9 +89,9 @@ public:
V8HiddenValue::setHiddenValue(isolate, result, v8InternalizedString(isolate, hiddenPropertyName), objectReference);
return result;
}
- static T* unwrap(v8::Local<v8::Object> object)
+ static T* unwrap(v8::Local<v8::Context> context, v8::Local<v8::Object> object)
{
- void* data = InspectorWrapperBase::unwrap(object, hiddenPropertyName);
+ void* data = InspectorWrapperBase::unwrap(context, object, hiddenPropertyName);
if (!data)
return nullptr;
return reinterpret_cast<WeakCallbackData*>(data)->m_impl.get();

Powered by Google App Engine
This is Rietveld 408576698