Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1455403003: Add an option to specify requested fields for fetching metadata. (Closed)

Created:
5 years, 1 month ago by mtomasz
Modified:
5 years, 1 month ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, Lei Zhang, tfarina, jam, nhiroki, tommycli, rginda+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an option to specify requested fields for fetching metadata. Fetching metadata is heavy, and it may cause calling stat() even though it's not needed (is_directory is obtainable without stat()). This CL adds the option. Backends will be updated to reflect it separately. Also, as another step base::File::Info will be replaced with storage::Entry or something similar with scoped_ptr's as members, to avoid reading a member which was not requested in |fields|. TEST=All current tests pass. But not really used yet, as backends ignore it. BUG=558191 Committed: https://crrev.com/132dc015c1928f080ec20a132d80d751a14e25c7 Cr-Commit-Position: refs/heads/master@{#360585}

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -64 lines) Patch
M chrome/browser/chromeos/drive/fileapi/async_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/fileapi/async_file_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/open_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/snapshot_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/device_media_async_file_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/media_file_validator_browsertest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 4 chunks +17 lines, -6 lines 0 comments Download
M content/browser/fileapi/fileapi_message_filter.cc View 1 2 chunks +9 lines, -4 lines 0 comments Download
M content/browser/fileapi/recursive_operation_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/public/test/async_file_test_helper.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M storage/browser/fileapi/async_file_util.h View 2 chunks +5 lines, -4 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.h View 1 chunk +1 line, -0 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.cc View 1 chunk +1 line, -0 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_context.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.cc View 1 chunk +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/file_system_operation.h View 2 chunks +9 lines, -0 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.h View 2 chunks +2 lines, -0 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (8 generated)
mtomasz
@tzik: PTAL. Thanks.
5 years, 1 month ago (2015-11-19 03:56:08 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455403003/20001
5 years, 1 month ago (2015-11-19 03:56:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-19 05:03:48 UTC) #7
tzik
lgtm
5 years, 1 month ago (2015-11-19 05:20:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455403003/20001
5 years, 1 month ago (2015-11-19 06:24:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/120103)
5 years, 1 month ago (2015-11-19 06:35:33 UTC) #12
mtomasz
@kinuko: PTAL at content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc and content/public/test/async_file_test_helper.cc Thanks
5 years, 1 month ago (2015-11-19 06:39:12 UTC) #14
kinuko
On 2015/11/19 06:39:12, mtomasz wrote: > @kinuko: PTAL at > content/browser/renderer_host/pepper/pepper_internal_file_ref_backend.cc and > content/public/test/async_file_test_helper.cc lgtm
5 years, 1 month ago (2015-11-19 14:52:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455403003/20001
5 years, 1 month ago (2015-11-19 15:21:27 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 15:44:16 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 15:45:21 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/132dc015c1928f080ec20a132d80d751a14e25c7
Cr-Commit-Position: refs/heads/master@{#360585}

Powered by Google App Engine
This is Rietveld 408576698