storage/browser/fileapi/file_system_context.cc - Issue 1455403003: Add an option to specify requested fields for fetching metadata.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_context.cc

Issue 1455403003: Add an option to specify requested fields for fetching metadata. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleaned up. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « storage/browser/fileapi/copy_or_move_operation_delegate.cc ('k') | storage/browser/fileapi/file_system_dir_url_request_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: storage/browser/fileapi/file_system_context.cc

diff --git a/storage/browser/fileapi/file_system_context.cc b/storage/browser/fileapi/file_system_context.cc

index 7b280c8f0874029424615457029e458e19eb495e..8c099e7d8abb2a6b48f04caa3ded898c1032968e 100644

--- a/storage/browser/fileapi/file_system_context.cc

+++ b/storage/browser/fileapi/file_system_context.cc

@@ -626,8 +626,12 @@ void FileSystemContext::DidOpenFileSystemForResolveURL(

DCHECK(result);

}

+ // TODO(mtomasz): Not all fields should be required for ResolveURL.

operation_runner()->GetMetadata(

- url, base::Bind(&DidGetMetadataForResolveURL, path, callback, info));

+ url, FileSystemOperation::GET_METADATA_FIELD_IS_DIRECTORY |

+ FileSystemOperation::GET_METADATA_FIELD_SIZE |

+ FileSystemOperation::GET_METADATA_FIELD_LAST_MODIFIED,

+ base::Bind(&DidGetMetadataForResolveURL, path, callback, info));

}

} // namespace storage