Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 1455323002: Use unique URLs rather than qualifiers to uniquify RenderProcesses. (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique URLs rather than qualifiers to uniquify RenderProcesses. This is so code in the browser has something tangible to call ConnectToApplication() on. When a RenderProcessHost creates a new renderer, it creates a URL of the style exe:chrome_renderer#, where # is the RenderProcess ID. It stores this string on the RenderProcessHost's SupportsUserData. Call content/browser/mojo/mojo_shell_client_host.h's GetMojoApplicationInstanceURL() with a particular RPH to get the URL to connect to it. R=jam@chromium.org http://crbug.com/558009 Committed: https://crrev.com/2c951446b15306358aa7167a956b005e6edec973 Cr-Commit-Position: refs/heads/master@{#360604}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -24 lines) Patch
M content/browser/mojo/mojo_shell_client_host.h View 1 2 chunks +11 lines, -5 lines 0 comments Download
M content/browser/mojo/mojo_shell_client_host.cc View 1 2 4 chunks +40 lines, -5 lines 0 comments Download
M mojo/shell/application_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/shell/application_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/shell_application_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/shell/shell_application_delegate.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ben Goodger (Google)
5 years, 1 month ago (2015-11-18 23:56:58 UTC) #1
jam
lgtm
5 years, 1 month ago (2015-11-19 15:20:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455323002/40001
5 years, 1 month ago (2015-11-19 15:29:55 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-19 16:43:56 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 16:44:42 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2c951446b15306358aa7167a956b005e6edec973
Cr-Commit-Position: refs/heads/master@{#360604}

Powered by Google App Engine
This is Rietveld 408576698