Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: mojo/shell/application_manager.cc

Issue 1455323002: Use unique URLs rather than qualifiers to uniquify RenderProcesses. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/shell/application_manager.h ('k') | mojo/shell/application_manager.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/shell/application_manager.cc
diff --git a/mojo/shell/application_manager.cc b/mojo/shell/application_manager.cc
index facade76eeea3e0faaf63f0f7e1b239aed3ff496..1e9e2a7da6f26a6b257e16f596c192a84cdba4da 100644
--- a/mojo/shell/application_manager.cc
+++ b/mojo/shell/application_manager.cc
@@ -117,15 +117,14 @@ ApplicationInstance* ApplicationManager::GetApplicationInstance(
}
void ApplicationManager::CreateInstanceForHandle(ScopedHandle channel,
- const GURL& url,
- const std::string& qualifier) {
+ const GURL& url) {
// Instances created by others are considered unique, and thus have no
// identity. As such they cannot be connected to by anyone else, and so we
// never call ConnectToClient().
// TODO(beng): GetPermissiveCapabilityFilter() here obviously cannot make it
// to production. See note in application_manager.mojom.
// http://crbug.com/555392
- Identity target_id(url, qualifier, GetPermissiveCapabilityFilter());
+ Identity target_id(url, std::string(), GetPermissiveCapabilityFilter());
InterfaceRequest<Application> application_request =
CreateInstance(target_id, base::Closure(), nullptr);
NativeRunner* runner =
« no previous file with comments | « mojo/shell/application_manager.h ('k') | mojo/shell/application_manager.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698