Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1455263002: Reland of This CL replaces e-mail with AccountId on user selection screen. (Closed)

Created:
5 years, 1 month ago by hcarmona
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of This CL replaces e-mail with AccountId on user selection screen. (patchset #1 id:1 of https://codereview.chromium.org/1454153002/ ) Reason for revert: This did not fix issues, reverting the revert. Original issue's description: > Revert of This CL replaces e-mail with AccountId on user selection screen. (patchset #12 id:220001 of https://codereview.chromium.org/1440583002/ ) > > Reason for revert: > Suspecting this CL for introducing failures on Mac 10.10 Release (ATI) > > First failure: https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Release%20%28ATI%29/builds/8148 > > Failing tests: > CastStreamingApiTestWithPixelOutput.EndToEnd > TabCaptureApiPixelTest.EndToEndThroughWebRTC > TabCaptureApiPixelTest.EndToEndWithoutRemoting > > Please update tests. > > Original issue's description: > > This CL replaces e-mail with AccountId on user selection screen. > > > > This CL replaces e-mail with serialized AccountId on user selection screen. > > It also adds simple AccountId Serialize/Deserialize methods suitable for > > passing AccountId to JS code. > > > > This is part of transition to AccountId. > > > > BUG=462823, 552034 > > TEST=manual > > > > Committed: https://crrev.com/1e24fe57a4ca921355bb1506f5a79627647a8c16 > > Cr-Commit-Position: refs/heads/master@{#360319} > > TBR=dzhioev@chromium.org,rogerta@chromium.org,stevenjb@chromium.org,oshima@chromium.org,alemate@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=462823, 552034 > > Committed: https://crrev.com/dede4c3836de2dddda5a484f098bba7152a6779b > Cr-Commit-Position: refs/heads/master@{#360369} TBR=dzhioev@chromium.org,rogerta@chromium.org,stevenjb@chromium.org,oshima@chromium.org,alemate@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462823, 552034 Committed: https://crrev.com/b1723ed336199cc11039ca4a2746e20a7ebc3e9a Cr-Commit-Position: refs/heads/master@{#360423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -253 lines) Patch
M ash/test/test_session_state_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc View 4 chunks +17 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.h View 6 chunks +15 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 12 chunks +63 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin_screen_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/models/user_board_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/views/user_board_view.h View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_display.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 21 chunks +21 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 9 chunks +36 lines, -37 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 3 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc View 2 chunks +18 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M components/login.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/login/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/login/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/login/base_screen_handler_utils.h View 3 chunks +17 lines, -3 lines 0 comments Download
M components/login/base_screen_handler_utils.cc View 3 chunks +23 lines, -0 lines 0 comments Download
M components/signin/core/account_id/account_id.h View 1 chunk +7 lines, -2 lines 0 comments Download
M components/signin/core/account_id/account_id.cc View 2 chunks +48 lines, -0 lines 0 comments Download
M components/user_manager/empty_user_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/empty_user_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/user_manager/user_info.h View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_info_impl.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/user_manager/user_info_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M components/user_manager/user_manager_base.h View 1 chunk +5 lines, -5 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 5 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hcarmona
Created Reland of This CL replaces e-mail with AccountId on user selection screen.
5 years, 1 month ago (2015-11-18 21:48:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455263002/1
5 years, 1 month ago (2015-11-18 21:50:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 21:53:05 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 21:53:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1723ed336199cc11039ca4a2746e20a7ebc3e9a
Cr-Commit-Position: refs/heads/master@{#360423}

Powered by Google App Engine
This is Rietveld 408576698