Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Unified Diff: components/signin/core/account_id/account_id.h

Issue 1455263002: Reland of This CL replaces e-mail with AccountId on user selection screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/login/base_screen_handler_utils.cc ('k') | components/signin/core/account_id/account_id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/account_id/account_id.h
diff --git a/components/signin/core/account_id/account_id.h b/components/signin/core/account_id/account_id.h
index 73be4501db5b0ab107937acced10ee17d478a5e2..9f72030bd0e73378dd1d16d66b445e12402d927a 100644
--- a/components/signin/core/account_id/account_id.h
+++ b/components/signin/core/account_id/account_id.h
@@ -45,8 +45,13 @@
static AccountId FromUserEmailGaiaId(const std::string& user_email,
const std::string& gaia_id);
- // std::string Serialize() const;
- // static AccountId Deserialize(const std::string& serialized);
+ // These are (for now) unstable and cannot be used to store serialized data to
+ // persistent storage. Only in-memory storage is safe.
+ // Serialize() returns JSON dictionary,
+ // Deserialize() restores AccountId after serialization.
+ std::string Serialize() const;
+ static bool Deserialize(const std::string& serialized,
+ AccountId* out_account_id);
private:
AccountId();
« no previous file with comments | « components/login/base_screen_handler_utils.cc ('k') | components/signin/core/account_id/account_id.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698