Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp

Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Draft4 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp
diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp
index e24a0d299506f74850f56787a3991ec2ef0e52b1..8df6717abecf352ce98915d1b74615ef80e56930 100644
--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp
+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePaintServer.cpp
@@ -92,8 +92,13 @@ static SVGPaintDescription requestPaint(const LayoutObject& object, const Comput
bool hasColor = false;
switch (paintType) {
case SVG_PAINTTYPE_CURRENTCOLOR:
- case SVG_PAINTTYPE_RGBCOLOR:
case SVG_PAINTTYPE_URI_CURRENTCOLOR:
+ color = style.visitedDependentColor(CSSPropertyColor);
+ if (!color.alpha())
fs 2015/11/25 17:23:00 I don't see why you need this.
hyunjunekim2 2015/11/26 01:07:26 And If don't has color(the color wasn't applied),
fs 2015/11/26 11:30:34 I suspect this is just a side-effect of the change
+ color = applyToFill ? svgStyle.fillPaintColor() : svgStyle.strokePaintColor();
+ hasColor = true;
+ break;
+ case SVG_PAINTTYPE_RGBCOLOR:
case SVG_PAINTTYPE_URI_RGBCOLOR:
color = applyToFill ? svgStyle.fillPaintColor() : svgStyle.strokePaintColor();
hasColor = true;

Powered by Google App Engine
This is Rietveld 408576698