Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 1455153003: Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Draft4 Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
index de1b88ab94adc02521bf8571a43feb6f6f5f4aaf..d12e2057ac075ec0d4d7344c3a3db5f832fd5d13 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
@@ -168,6 +168,12 @@ void StyleBuilderFunctions::applyValueCSSPropertyColor(StyleResolverState& state
return;
}
+ bool isFillCurrentColor = state.style()->svgStyle().isFillColorCurrentColor();
+ bool isStrokeCurrentColor = state.style()->svgStyle().isStrokeColorCurrentColor();
+
+ if (isFillCurrentColor || isStrokeCurrentColor)
fs 2015/11/25 17:23:00 Why do you do this?
hyunjunekim2 2015/11/26 01:07:26 About the second case, the 'color="red"' was appli
fs 2015/11/26 11:30:34 I think I understand what you mean, but I think th
+ return;
+
if (state.applyPropertyToRegularStyle())
state.style()->setColor(StyleBuilderConverter::convertColor(state, *value));
if (state.applyPropertyToVisitedLinkStyle())

Powered by Google App Engine
This is Rietveld 408576698