Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke'

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
index de1b88ab94adc02521bf8571a43feb6f6f5f4aaf..d12e2057ac075ec0d4d7344c3a3db5f832fd5d13 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
@@ -168,6 +168,12 @@ void StyleBuilderFunctions::applyValueCSSPropertyColor(StyleResolverState& state
         return;
     }
 
+    bool isFillCurrentColor = state.style()->svgStyle().isFillColorCurrentColor();
+    bool isStrokeCurrentColor = state.style()->svgStyle().isStrokeColorCurrentColor();
+
+    if (isFillCurrentColor || isStrokeCurrentColor)

[fs, 2015/11/25 17:23:00]

Why do you do this?

[hyunjunekim2, 2015/11/26 01:07:26]

About the second case, the 'color="red"' was applied on style.color().
So before set color, i checked whether has currentColor or not. If have
currentColor about 'fill' (and 'stroke'), don't was apply.

[fs, 2015/11/26 11:30:34]

I think I understand what you mean, but I think the (current) behavior here is
wrong per my reading of https://drafts.csswg.org/css-color/#currentcolor-color .
It's possibly a different bug than the one about animation, so it could make
sense to make that change in semantics first.

+        return;
+
     if (state.applyPropertyToRegularStyle())
         state.style()->setColor(StyleBuilderConverter::convertColor(state, *value));
     if (state.applyPropertyToVisitedLinkStyle())