Fix animation of 'color' w/ currentColor for SVG 'fill' and 'stroke'

third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
@@ skipping 150 matching lines @@
 }
 
 void StyleBuilderFunctions::applyValueCSSPropertyColor(StyleResolverState& state, CSSValue* value)
 {
     // As per the spec, 'color: currentColor' is treated as 'color: inherit'
     if (value->isPrimitiveValue() && toCSSPrimitiveValue(value)->getValueID() == CSSValueCurrentcolor) {
         applyInheritCSSPropertyColor(state);
         return;
     }
 
+    bool isFillCurrentColor = state.style()->svgStyle().isFillColorCurrentColor();
+    bool isStrokeCurrentColor = state.style()->svgStyle().isStrokeColorCurrentColor();
+
+    if (isFillCurrentColor || isStrokeCurrentColor)

[fs, 2015/11/25 17:23:00]

Why do you do this?

[hyunjunekim2, 2015/11/26 01:07:26]

About the second case, the 'color="red"' was applied on style.color().
So before set color, i checked whether has currentColor or not. If have
currentColor about 'fill' (and 'stroke'), don't was apply.

[fs, 2015/11/26 11:30:34]

I think I understand what you mean, but I think the (current) behavior here is
wrong per my reading of https://drafts.csswg.org/css-color/#currentcolor-color .
It's possibly a different bug than the one about animation, so it could make
sense to make that change in semantics first.

+        return;
+
     if (state.applyPropertyToRegularStyle())
         state.style()->setColor(StyleBuilderConverter::convertColor(state, *value));
     if (state.applyPropertyToVisitedLinkStyle())
         state.style()->setVisitedLinkColor(StyleBuilderConverter::convertColor(state, *value, true));
 }
 
 void StyleBuilderFunctions::applyInitialCSSPropertyCursor(StyleResolverState& state)
 {
     state.style()->clearCursorList();
     state.style()->setCursor(ComputedStyle::initialCursor());
@@ skipping 681 matching lines @@
         return;
     case CSSValueSuper:
         svgStyle.setBaselineShift(BS_SUPER);
         return;
     default:
         ASSERT_NOT_REACHED();
     }
 }
 
 } // namespace blink