src/js/math.js - Issue 1455123002: [turbofan] Check word32 -> float64 conversion with input type/output truncation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/math.js

Issue 1455123002: [turbofan] Check word32 -> float64 conversion with input type/output truncation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Get rid of the guards Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/math.js

diff --git a/src/js/math.js b/src/js/math.js

index ba2b2186f4aebc56396c56ecb349f9ae33739825..6a0beef43c10b0bcb4263d008ed331ac1980b16a 100644

--- a/src/js/math.js

+++ b/src/js/math.js

@@ -282,7 +282,7 @@ endmacro

function CubeRoot(x) {

var approx_hi = MathFloorJS(%_DoubleHi(x) / 3) + 0x2A9F7893;

- var approx = %_ConstructDouble(approx_hi, 0);

+ var approx = %_ConstructDouble(approx_hi | 0, 0);

approx = NEWTON_ITERATION_CBRT(x, approx);

« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | no next file » | no next file with comments »