Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: src/compiler/simplified-lowering.cc

Issue 1455123002: [turbofan] Check word32 -> float64 conversion with input type/output truncation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Get rid of the guards Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/representation-change.h ('k') | src/js/math.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/simplified-lowering.cc
diff --git a/src/compiler/simplified-lowering.cc b/src/compiler/simplified-lowering.cc
index 6dfc9ae9fc57693aaa02792c32d4fe99638f32c2..5033c1919ec073acc57dda0b34a8c8b6f52169f4 100644
--- a/src/compiler/simplified-lowering.cc
+++ b/src/compiler/simplified-lowering.cc
@@ -400,18 +400,13 @@ class RepresentationSelector {
if (type != OpParameter<MachineType>(node)) {
NodeProperties::ChangeOp(node, lowering->common()->Phi(type, values));
}
+ }
- // Convert inputs to the output representation of this phi.
- for (int i = 0; i < node->InputCount(); i++) {
- ProcessInput(node, i, i < values ? output_type : 0);
- }
- } else {
- // Propagate {use} of the phi to value inputs, and 0 to control.
- MachineType use_type =
- static_cast<MachineType>((use & kTypeMask) | output);
- for (int i = 0; i < node->InputCount(); i++) {
- ProcessInput(node, i, i < values ? use_type : 0);
- }
+ // Convert inputs to the output representation of this phi, pass the
+ // use truncation along.
+ MachineType use_type = static_cast<MachineType>((use & kTypeMask) | output);
+ for (int i = 0; i < node->InputCount(); i++) {
+ ProcessInput(node, i, i < values ? use_type : 0);
}
}
« no previous file with comments | « src/compiler/representation-change.h ('k') | src/js/math.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698