Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1455103002: [turbofan] Only infer signedness for Float64->Word32 representation change from the input type. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, titzer
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only infer signedness for Float64->Word32 representation change from the input type. If the input type does not help us, we are conservative and truncate (rather than guessing signed). Committed: https://crrev.com/a9fa0498e1cc4e53f63ef0f927b86793a4bd4cc6 Cr-Commit-Position: refs/heads/master@{#32075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -36 lines) Patch
M src/compiler/representation-change.h View 3 chunks +16 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 2 chunks +9 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +12 lines, -8 lines 0 comments Download
A + test/mjsunit/compiler/regress-f64-w32-change.js View 1 chunk +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-11-18 09:28:54 UTC) #2
Benedikt Meurer
Nice. LGTM.
5 years, 1 month ago (2015-11-18 09:30:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455103002/1
5 years, 1 month ago (2015-11-18 09:58:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 10:02:16 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 10:02:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9fa0498e1cc4e53f63ef0f927b86793a4bd4cc6
Cr-Commit-Position: refs/heads/master@{#32075}

Powered by Google App Engine
This is Rietveld 408576698