[turbofan] Only infer signedness for Float64->Word32 representation change from the input type.

src/compiler/representation-change.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_REPRESENTATION_CHANGE_H_
 #define V8_COMPILER_REPRESENTATION_CHANGE_H_
 
 #include <sstream>
 
 #include "src/base/bits.h"
@@ skipping 40 matching lines @@
     }
     if (use_type & kRepTagged) {
       return GetTaggedRepresentationFor(node, output_type);
     } else if (use_type & kRepFloat32) {
       return GetFloat32RepresentationFor(node, output_type);
     } else if (use_type & kRepFloat64) {
       return GetFloat64RepresentationFor(node, output_type);
     } else if (use_type & kRepBit) {
       return GetBitRepresentationFor(node, output_type);
     } else if (IsWord(use_type)) {
-      return GetWord32RepresentationFor(node, output_type,
-                                        use_type & kTypeUint32);
+      return GetWord32RepresentationFor(node, output_type);
     } else if (use_type & kRepWord64) {
       return GetWord64RepresentationFor(node, output_type);
     } else {
       return node;
     }
   }
 
   Node* GetTaggedRepresentationFor(Node* node, MachineTypeUnion output_type) {
     // Eagerly fold representation changes for constants.
     switch (node->opcode()) {
@@ skipping 165 matching lines @@
       op = machine()->TruncateFloat64ToInt32(TruncationMode::kJavaScript);
     } else if (output_type & kRepTagged) {
       node = InsertChangeTaggedToFloat64(node);
       op = machine()->TruncateFloat64ToInt32(TruncationMode::kJavaScript);
     } else {
       return TypeError(node, output_type, kRepWord32);
     }
     return jsgraph()->graph()->NewNode(op, node);
   }
 
-  Node* GetWord32RepresentationFor(Node* node, MachineTypeUnion output_type,
-                                   bool use_unsigned) {
+  Node* GetWord32RepresentationFor(Node* node, MachineTypeUnion output_type) {
     // Eagerly fold representation changes for constants.
     switch (node->opcode()) {
       case IrOpcode::kInt32Constant:
         return node;  // No change necessary.
       case IrOpcode::kFloat32Constant:
         return MakeInt32Constant(OpParameter<float>(node));
       case IrOpcode::kNumberConstant:
       case IrOpcode::kFloat64Constant:
         return MakeInt32Constant(OpParameter<double>(node));
       default:
         break;
     }
     // Select the correct X -> Word32 operator.
     const Operator* op;
+    Type* type = NodeProperties::GetType(node);
     if (output_type & kRepBit) {
       return node;  // Sloppy comparison -> word32
     } else if (output_type & kRepFloat64) {
-      if (output_type & kTypeUint32 || use_unsigned) {
+      if (output_type & kTypeUint32 || type->Is(Type::Unsigned32())) {
         op = machine()->ChangeFloat64ToUint32();
+      } else if (output_type & kTypeInt32 || type->Is(Type::Signed32())) {
+        op = machine()->ChangeFloat64ToInt32();
       } else {
-        op = machine()->ChangeFloat64ToInt32();
+        op = machine()->TruncateFloat64ToInt32(TruncationMode::kJavaScript);
       }
     } else if (output_type & kRepFloat32) {
       node = InsertChangeFloat32ToFloat64(node);  // float32 -> float64 -> int32
-      if (output_type & kTypeUint32 || use_unsigned) {
+      if (output_type & kTypeUint32 || type->Is(Type::Unsigned32())) {
         op = machine()->ChangeFloat64ToUint32();
+      } else if (output_type & kTypeInt32 || type->Is(Type::Signed32())) {
+        op = machine()->ChangeFloat64ToInt32();
       } else {
-        op = machine()->ChangeFloat64ToInt32();
+        op = machine()->TruncateFloat64ToInt32(TruncationMode::kJavaScript);
       }
     } else if (output_type & kRepTagged) {
-      if (output_type & kTypeUint32 || use_unsigned) {
+      if (output_type & kTypeUint32 || type->Is(Type::Unsigned32())) {
         op = simplified()->ChangeTaggedToUint32();
+      } else if (output_type & kTypeInt32 || type->Is(Type::Signed32())) {
+        op = simplified()->ChangeTaggedToInt32();
       } else {
-        op = simplified()->ChangeTaggedToInt32();
+        node = InsertChangeTaggedToFloat64(node);
+        op = machine()->TruncateFloat64ToInt32(TruncationMode::kJavaScript);
       }
     } else {
       return TypeError(node, output_type, kRepWord32);
     }
     return jsgraph()->graph()->NewNode(op, node);
   }
 
   Node* GetBitRepresentationFor(Node* node, MachineTypeUnion output_type) {
     // Eagerly fold representation changes for constants.
     switch (node->opcode()) {
@@ skipping 164 matching lines @@
   Factory* factory() const { return isolate()->factory(); }
   SimplifiedOperatorBuilder* simplified() { return jsgraph()->simplified(); }
   MachineOperatorBuilder* machine() { return jsgraph()->machine(); }
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_REPRESENTATION_CHANGE_H_