Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 1455023002: cc: Replace Pass() with std::move() in some subdirs. (Closed)

Created:
5 years, 1 month ago by danakj
Modified:
5 years, 1 month ago
Reviewers:
vmpstr, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, feature-media-reviews_chromium.org, miu+watch_chromium.org, piman, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pass-cc
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Replace Pass() with std::move() in some subdirs. This hits the following: cc/layers/ cc/output/ cc/quads/ cc/resources/ cc/scheduler/ cc/surfaces/ cc/trees/ R=enne, vmpstr BUG=557422 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a04855af140e24ed3ec3f59da178837b3d32d9c4 Cr-Commit-Position: refs/heads/master@{#360405}

Patch Set 1 #

Patch Set 2 : pass-cc2: . #

Patch Set 3 : pass-cc2: rebase #

Patch Set 4 : pass-cc2: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1062 lines, -1066 lines) Patch
M cc/layers/delegated_frame_provider.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/delegated_frame_provider_unittest.cc View 14 chunks +18 lines, -18 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M cc/layers/delegated_renderer_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/layer_iterator_unittest.cc View 3 chunks +23 lines, -23 lines 0 comments Download
M cc/layers/layer_unittest.cc View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
M cc/layers/layer_utils_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/layers/picture_image_layer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_image_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/render_surface_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 2 7 chunks +11 lines, -11 lines 0 comments Download
M cc/layers/surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M cc/layers/video_layer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/layers/video_layer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/bsp_tree.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M cc/output/bsp_tree_unittest.cc View 1 2 8 chunks +22 lines, -22 lines 0 comments Download
M cc/output/compositor_frame.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/copy_output_request.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/output/copy_output_result.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/output/copy_output_result.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/direct_renderer.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 2 5 chunks +8 lines, -8 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 2 14 chunks +14 lines, -14 lines 0 comments Download
M cc/output/output_surface.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/overlay_unittest.cc View 1 2 51 chunks +51 lines, -51 lines 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 50 chunks +70 lines, -68 lines 0 comments Download
M cc/output/renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/output/texture_mailbox_deleter.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/draw_polygon.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M cc/quads/render_pass.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/render_pass_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/resource_pool.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 30 chunks +31 lines, -31 lines 0 comments Download
M cc/resources/video_resource_updater_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/scheduler/begin_frame_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M cc/surfaces/display_unittest.cc View 16 chunks +23 lines, -22 lines 0 comments Download
M cc/surfaces/onscreen_display_client.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_aggregator_perftest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M cc/surfaces/surface_aggregator_unittest.cc View 1 2 19 chunks +40 lines, -38 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_display_output_surface_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/surfaces/surface_factory_unittest.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M cc/surfaces/surface_hittest_unittest.cc View 1 2 8 chunks +8 lines, -8 lines 0 comments Download
M cc/surfaces/surfaces_pixeltest.cc View 6 chunks +18 lines, -18 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 2 15 chunks +20 lines, -20 lines 0 comments Download
M cc/trees/latency_info_swap_promise_monitor.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 14 chunks +23 lines, -23 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 26 chunks +60 lines, -60 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 8 chunks +11 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 70 chunks +142 lines, -139 lines 0 comments Download
M cc/trees/layer_tree_host_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_blending.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_readback.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_tiles.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 17 chunks +23 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 2 3 chunks +8 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation_timelines.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_delegated.cc View 1 2 47 chunks +51 lines, -51 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 1 2 33 chunks +62 lines, -62 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 2 6 chunks +7 lines, -7 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 5 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/thread_proxy.cc View 1 2 9 chunks +14 lines, -13 lines 0 comments Download
M cc/trees/threaded_channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/threaded_channel_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 2 4 chunks +10 lines, -9 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 2 11 chunks +39 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danakj
5 years, 1 month ago (2015-11-18 01:00:27 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455023002/1
5 years, 1 month ago (2015-11-18 01:05:33 UTC) #3
enne (OOO)
lgtm
5 years, 1 month ago (2015-11-18 18:16:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1455023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1455023002/60001
5 years, 1 month ago (2015-11-18 19:25:32 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-18 20:39:21 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 20:40:14 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a04855af140e24ed3ec3f59da178837b3d32d9c4
Cr-Commit-Position: refs/heads/master@{#360405}

Powered by Google App Engine
This is Rietveld 408576698