| OLD | NEW |
| 1 // Copyright 2011 The Chromium Authors. All rights reserved. | 1 // Copyright 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "cc/trees/tree_synchronizer.h" | 5 #include "cc/trees/tree_synchronizer.h" |
| 6 | 6 |
| 7 #include <algorithm> | 7 #include <algorithm> |
| 8 #include <set> | 8 #include <set> |
| 9 #include <vector> | 9 #include <vector> |
| 10 | 10 |
| (...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 260 | 260 |
| 261 // Add a new layer to the Layer side | 261 // Add a new layer to the Layer side |
| 262 layer_tree_root->children()[0]->AddChild( | 262 layer_tree_root->children()[0]->AddChild( |
| 263 MockLayer::Create(layer_settings_, &layer_impl_destruction_list)); | 263 MockLayer::Create(layer_settings_, &layer_impl_destruction_list)); |
| 264 // Remove one. | 264 // Remove one. |
| 265 layer_tree_root->children()[1]->RemoveFromParent(); | 265 layer_tree_root->children()[1]->RemoveFromParent(); |
| 266 int second_layer_impl_id = layer_impl_tree_root->children()[1]->id(); | 266 int second_layer_impl_id = layer_impl_tree_root->children()[1]->id(); |
| 267 | 267 |
| 268 // Synchronize again. After the sync the trees should be equivalent and we | 268 // Synchronize again. After the sync the trees should be equivalent and we |
| 269 // should have created and destroyed one LayerImpl. | 269 // should have created and destroyed one LayerImpl. |
| 270 layer_impl_tree_root = | 270 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 271 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 271 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 272 layer_impl_tree_root.Pass(), | 272 host_->active_tree()); |
| 273 host_->active_tree()); | |
| 274 ExpectTreesAreIdentical(layer_tree_root.get(), | 273 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 275 layer_impl_tree_root.get(), | 274 layer_impl_tree_root.get(), |
| 276 host_->active_tree()); | 275 host_->active_tree()); |
| 277 | 276 |
| 278 ASSERT_EQ(1u, layer_impl_destruction_list.size()); | 277 ASSERT_EQ(1u, layer_impl_destruction_list.size()); |
| 279 EXPECT_EQ(second_layer_impl_id, layer_impl_destruction_list[0]); | 278 EXPECT_EQ(second_layer_impl_id, layer_impl_destruction_list[0]); |
| 280 } | 279 } |
| 281 | 280 |
| 282 // Constructs a very simple tree and checks that a stacking-order change is | 281 // Constructs a very simple tree and checks that a stacking-order change is |
| 283 // tracked properly. | 282 // tracked properly. |
| (...skipping 21 matching lines...) Expand all Loading... |
| 305 | 304 |
| 306 // We have to push properties to pick up the destruction list pointer. | 305 // We have to push properties to pick up the destruction list pointer. |
| 307 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 306 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 308 layer_impl_tree_root.get()); | 307 layer_impl_tree_root.get()); |
| 309 | 308 |
| 310 layer_impl_tree_root->ResetAllChangeTrackingForSubtree(); | 309 layer_impl_tree_root->ResetAllChangeTrackingForSubtree(); |
| 311 | 310 |
| 312 // re-insert the layer and sync again. | 311 // re-insert the layer and sync again. |
| 313 child2->RemoveFromParent(); | 312 child2->RemoveFromParent(); |
| 314 layer_tree_root->AddChild(child2); | 313 layer_tree_root->AddChild(child2); |
| 315 layer_impl_tree_root = | 314 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 316 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 315 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 317 layer_impl_tree_root.Pass(), | 316 host_->active_tree()); |
| 318 host_->active_tree()); | |
| 319 ExpectTreesAreIdentical(layer_tree_root.get(), | 317 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 320 layer_impl_tree_root.get(), | 318 layer_impl_tree_root.get(), |
| 321 host_->active_tree()); | 319 host_->active_tree()); |
| 322 | 320 |
| 323 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 321 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 324 layer_impl_tree_root.get()); | 322 layer_impl_tree_root.get()); |
| 325 | 323 |
| 326 // Check that the impl thread properly tracked the change. | 324 // Check that the impl thread properly tracked the change. |
| 327 EXPECT_FALSE(layer_impl_tree_root->LayerPropertyChanged()); | 325 EXPECT_FALSE(layer_impl_tree_root->LayerPropertyChanged()); |
| 328 EXPECT_FALSE(layer_impl_tree_root->children()[0]->LayerPropertyChanged()); | 326 EXPECT_FALSE(layer_impl_tree_root->children()[0]->LayerPropertyChanged()); |
| (...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 422 layer_tree_root->AddChild(layer_d); | 420 layer_tree_root->AddChild(layer_d); |
| 423 layer_a->RemoveAllChildren(); | 421 layer_a->RemoveAllChildren(); |
| 424 layer_d->AddChild(layer_a); | 422 layer_d->AddChild(layer_a); |
| 425 layer_c->RemoveAllChildren(); | 423 layer_c->RemoveAllChildren(); |
| 426 layer_d->AddChild(layer_c); | 424 layer_d->AddChild(layer_c); |
| 427 layer_b->RemoveAllChildren(); | 425 layer_b->RemoveAllChildren(); |
| 428 layer_c->AddChild(layer_b); | 426 layer_c->AddChild(layer_b); |
| 429 | 427 |
| 430 // After another synchronize our trees should match and we should not have | 428 // After another synchronize our trees should match and we should not have |
| 431 // destroyed any LayerImpls | 429 // destroyed any LayerImpls |
| 432 layer_impl_tree_root = | 430 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 433 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 431 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 434 layer_impl_tree_root.Pass(), | 432 host_->active_tree()); |
| 435 host_->active_tree()); | |
| 436 ExpectTreesAreIdentical(layer_tree_root.get(), | 433 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 437 layer_impl_tree_root.get(), | 434 layer_impl_tree_root.get(), |
| 438 host_->active_tree()); | 435 host_->active_tree()); |
| 439 | 436 |
| 440 EXPECT_EQ(0u, layer_impl_destruction_list.size()); | 437 EXPECT_EQ(0u, layer_impl_destruction_list.size()); |
| 441 } | 438 } |
| 442 | 439 |
| 443 // Constructs a very simple tree, synchronizes it, then synchronizes to a | 440 // Constructs a very simple tree, synchronizes it, then synchronizes to a |
| 444 // totally new tree. All layers from the old tree should be deleted. | 441 // totally new tree. All layers from the old tree should be deleted. |
| 445 TEST_F(TreeSynchronizerTest, SyncSimpleTreeThenDestroy) { | 442 TEST_F(TreeSynchronizerTest, SyncSimpleTreeThenDestroy) { |
| (...skipping 23 matching lines...) Expand all Loading... |
| 469 TreeSynchronizer::PushProperties(old_layer_tree_root.get(), | 466 TreeSynchronizer::PushProperties(old_layer_tree_root.get(), |
| 470 layer_impl_tree_root.get()); | 467 layer_impl_tree_root.get()); |
| 471 | 468 |
| 472 // Remove all children on the Layer side. | 469 // Remove all children on the Layer side. |
| 473 old_layer_tree_root->RemoveAllChildren(); | 470 old_layer_tree_root->RemoveAllChildren(); |
| 474 | 471 |
| 475 // Synchronize again. After the sync all LayerImpls from the old tree should | 472 // Synchronize again. After the sync all LayerImpls from the old tree should |
| 476 // be deleted. | 473 // be deleted. |
| 477 scoped_refptr<Layer> new_layer_tree_root = Layer::Create(layer_settings_); | 474 scoped_refptr<Layer> new_layer_tree_root = Layer::Create(layer_settings_); |
| 478 host_->SetRootLayer(new_layer_tree_root); | 475 host_->SetRootLayer(new_layer_tree_root); |
| 479 layer_impl_tree_root = | 476 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 480 TreeSynchronizer::SynchronizeTrees(new_layer_tree_root.get(), | 477 new_layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 481 layer_impl_tree_root.Pass(), | 478 host_->active_tree()); |
| 482 host_->active_tree()); | |
| 483 ExpectTreesAreIdentical(new_layer_tree_root.get(), | 479 ExpectTreesAreIdentical(new_layer_tree_root.get(), |
| 484 layer_impl_tree_root.get(), | 480 layer_impl_tree_root.get(), |
| 485 host_->active_tree()); | 481 host_->active_tree()); |
| 486 | 482 |
| 487 ASSERT_EQ(3u, layer_impl_destruction_list.size()); | 483 ASSERT_EQ(3u, layer_impl_destruction_list.size()); |
| 488 | 484 |
| 489 EXPECT_TRUE(std::find(layer_impl_destruction_list.begin(), | 485 EXPECT_TRUE(std::find(layer_impl_destruction_list.begin(), |
| 490 layer_impl_destruction_list.end(), | 486 layer_impl_destruction_list.end(), |
| 491 old_tree_root_layer_id) != | 487 old_tree_root_layer_id) != |
| 492 layer_impl_destruction_list.end()); | 488 layer_impl_destruction_list.end()); |
| (...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 527 scoped_ptr<LayerImpl> layer_impl_tree_root = | 523 scoped_ptr<LayerImpl> layer_impl_tree_root = |
| 528 TreeSynchronizer::SynchronizeTrees( | 524 TreeSynchronizer::SynchronizeTrees( |
| 529 layer_tree_root.get(), nullptr, host_->active_tree()); | 525 layer_tree_root.get(), nullptr, host_->active_tree()); |
| 530 | 526 |
| 531 ExpectTreesAreIdentical(layer_tree_root.get(), | 527 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 532 layer_impl_tree_root.get(), | 528 layer_impl_tree_root.get(), |
| 533 host_->active_tree()); | 529 host_->active_tree()); |
| 534 | 530 |
| 535 // Remove the mask layer. | 531 // Remove the mask layer. |
| 536 layer_tree_root->children()[0]->SetMaskLayer(NULL); | 532 layer_tree_root->children()[0]->SetMaskLayer(NULL); |
| 537 layer_impl_tree_root = | 533 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 538 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 534 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 539 layer_impl_tree_root.Pass(), | 535 host_->active_tree()); |
| 540 host_->active_tree()); | |
| 541 ExpectTreesAreIdentical(layer_tree_root.get(), | 536 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 542 layer_impl_tree_root.get(), | 537 layer_impl_tree_root.get(), |
| 543 host_->active_tree()); | 538 host_->active_tree()); |
| 544 | 539 |
| 545 // Remove the replica layer. | 540 // Remove the replica layer. |
| 546 layer_tree_root->children()[1]->SetReplicaLayer(NULL); | 541 layer_tree_root->children()[1]->SetReplicaLayer(NULL); |
| 547 layer_impl_tree_root = | 542 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 548 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 543 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 549 layer_impl_tree_root.Pass(), | 544 host_->active_tree()); |
| 550 host_->active_tree()); | |
| 551 ExpectTreesAreIdentical(layer_tree_root.get(), | 545 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 552 layer_impl_tree_root.get(), | 546 layer_impl_tree_root.get(), |
| 553 host_->active_tree()); | 547 host_->active_tree()); |
| 554 | 548 |
| 555 // Remove the replica mask. | 549 // Remove the replica mask. |
| 556 replica_layer_with_mask->SetMaskLayer(NULL); | 550 replica_layer_with_mask->SetMaskLayer(NULL); |
| 557 layer_impl_tree_root = | 551 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 558 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 552 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 559 layer_impl_tree_root.Pass(), | 553 host_->active_tree()); |
| 560 host_->active_tree()); | |
| 561 ExpectTreesAreIdentical(layer_tree_root.get(), | 554 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 562 layer_impl_tree_root.get(), | 555 layer_impl_tree_root.get(), |
| 563 host_->active_tree()); | 556 host_->active_tree()); |
| 564 } | 557 } |
| 565 | 558 |
| 566 TEST_F(TreeSynchronizerTest, SynchronizeAnimations) { | 559 TEST_F(TreeSynchronizerTest, SynchronizeAnimations) { |
| 567 LayerTreeSettings settings; | 560 LayerTreeSettings settings; |
| 568 FakeImplTaskRunnerProvider task_runner_provider; | 561 FakeImplTaskRunnerProvider task_runner_provider; |
| 569 FakeRenderingStatsInstrumentation stats_instrumentation; | 562 FakeRenderingStatsInstrumentation stats_instrumentation; |
| 570 TestSharedBitmapManager shared_bitmap_manager; | 563 TestSharedBitmapManager shared_bitmap_manager; |
| 571 TestTaskGraphRunner task_graph_runner; | 564 TestTaskGraphRunner task_graph_runner; |
| 572 scoped_ptr<LayerTreeHostImpl> host_impl = LayerTreeHostImpl::Create( | 565 scoped_ptr<LayerTreeHostImpl> host_impl = LayerTreeHostImpl::Create( |
| 573 settings, nullptr, &task_runner_provider, &stats_instrumentation, | 566 settings, nullptr, &task_runner_provider, &stats_instrumentation, |
| 574 &shared_bitmap_manager, nullptr, &task_graph_runner, 0); | 567 &shared_bitmap_manager, nullptr, &task_graph_runner, 0); |
| 575 | 568 |
| 576 scoped_refptr<Layer> layer_tree_root = Layer::Create(layer_settings_); | 569 scoped_refptr<Layer> layer_tree_root = Layer::Create(layer_settings_); |
| 577 host_->SetRootLayer(layer_tree_root); | 570 host_->SetRootLayer(layer_tree_root); |
| 578 | 571 |
| 579 layer_tree_root->SetLayerAnimationControllerForTest( | 572 layer_tree_root->SetLayerAnimationControllerForTest( |
| 580 FakeLayerAnimationController::Create()); | 573 FakeLayerAnimationController::Create()); |
| 581 | 574 |
| 582 EXPECT_FALSE(static_cast<FakeLayerAnimationController*>( | 575 EXPECT_FALSE(static_cast<FakeLayerAnimationController*>( |
| 583 layer_tree_root->layer_animation_controller())->SynchronizedAnimations()); | 576 layer_tree_root->layer_animation_controller())->SynchronizedAnimations()); |
| 584 | 577 |
| 585 scoped_ptr<LayerImpl> layer_impl_tree_root = | 578 scoped_ptr<LayerImpl> layer_impl_tree_root = |
| 586 TreeSynchronizer::SynchronizeTrees( | 579 TreeSynchronizer::SynchronizeTrees( |
| 587 layer_tree_root.get(), nullptr, host_->active_tree()); | 580 layer_tree_root.get(), nullptr, host_->active_tree()); |
| 588 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 581 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 589 layer_impl_tree_root.get()); | 582 layer_impl_tree_root.get()); |
| 590 layer_impl_tree_root = | 583 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 591 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 584 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 592 layer_impl_tree_root.Pass(), | 585 host_->active_tree()); |
| 593 host_->active_tree()); | |
| 594 | 586 |
| 595 EXPECT_TRUE(static_cast<FakeLayerAnimationController*>( | 587 EXPECT_TRUE(static_cast<FakeLayerAnimationController*>( |
| 596 layer_tree_root->layer_animation_controller())->SynchronizedAnimations()); | 588 layer_tree_root->layer_animation_controller())->SynchronizedAnimations()); |
| 597 } | 589 } |
| 598 | 590 |
| 599 TEST_F(TreeSynchronizerTest, SynchronizeScrollParent) { | 591 TEST_F(TreeSynchronizerTest, SynchronizeScrollParent) { |
| 600 LayerTreeSettings settings; | 592 LayerTreeSettings settings; |
| 601 FakeImplTaskRunnerProvider task_runner_provider; | 593 FakeImplTaskRunnerProvider task_runner_provider; |
| 602 FakeRenderingStatsInstrumentation stats_instrumentation; | 594 FakeRenderingStatsInstrumentation stats_instrumentation; |
| 603 TestSharedBitmapManager shared_bitmap_manager; | 595 TestSharedBitmapManager shared_bitmap_manager; |
| (...skipping 21 matching lines...) Expand all Loading... |
| 625 layer_impl_tree_root.get()); | 617 layer_impl_tree_root.get()); |
| 626 { | 618 { |
| 627 SCOPED_TRACE("case one"); | 619 SCOPED_TRACE("case one"); |
| 628 ExpectTreesAreIdentical(layer_tree_root.get(), | 620 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 629 layer_impl_tree_root.get(), | 621 layer_impl_tree_root.get(), |
| 630 host_impl->active_tree()); | 622 host_impl->active_tree()); |
| 631 } | 623 } |
| 632 | 624 |
| 633 // Remove the first scroll child. | 625 // Remove the first scroll child. |
| 634 layer_tree_root->children()[1]->RemoveFromParent(); | 626 layer_tree_root->children()[1]->RemoveFromParent(); |
| 635 layer_impl_tree_root = | 627 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 636 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 628 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 637 layer_impl_tree_root.Pass(), | 629 host_impl->active_tree()); |
| 638 host_impl->active_tree()); | |
| 639 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 630 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 640 layer_impl_tree_root.get()); | 631 layer_impl_tree_root.get()); |
| 641 { | 632 { |
| 642 SCOPED_TRACE("case two"); | 633 SCOPED_TRACE("case two"); |
| 643 ExpectTreesAreIdentical(layer_tree_root.get(), | 634 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 644 layer_impl_tree_root.get(), | 635 layer_impl_tree_root.get(), |
| 645 host_impl->active_tree()); | 636 host_impl->active_tree()); |
| 646 } | 637 } |
| 647 | 638 |
| 648 // Add an additional scroll layer. | 639 // Add an additional scroll layer. |
| 649 scoped_refptr<Layer> additional_scroll_child = Layer::Create(layer_settings_); | 640 scoped_refptr<Layer> additional_scroll_child = Layer::Create(layer_settings_); |
| 650 layer_tree_root->AddChild(additional_scroll_child); | 641 layer_tree_root->AddChild(additional_scroll_child); |
| 651 additional_scroll_child->SetScrollParent(scroll_parent.get()); | 642 additional_scroll_child->SetScrollParent(scroll_parent.get()); |
| 652 layer_impl_tree_root = | 643 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 653 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 644 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 654 layer_impl_tree_root.Pass(), | 645 host_impl->active_tree()); |
| 655 host_impl->active_tree()); | |
| 656 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 646 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 657 layer_impl_tree_root.get()); | 647 layer_impl_tree_root.get()); |
| 658 { | 648 { |
| 659 SCOPED_TRACE("case three"); | 649 SCOPED_TRACE("case three"); |
| 660 ExpectTreesAreIdentical(layer_tree_root.get(), | 650 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 661 layer_impl_tree_root.get(), | 651 layer_impl_tree_root.get(), |
| 662 host_impl->active_tree()); | 652 host_impl->active_tree()); |
| 663 } | 653 } |
| 664 } | 654 } |
| 665 | 655 |
| (...skipping 29 matching lines...) Expand all Loading... |
| 695 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 685 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 696 layer_impl_tree_root.get()); | 686 layer_impl_tree_root.get()); |
| 697 ExpectTreesAreIdentical(layer_tree_root.get(), | 687 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 698 layer_impl_tree_root.get(), | 688 layer_impl_tree_root.get(), |
| 699 host_impl->active_tree()); | 689 host_impl->active_tree()); |
| 700 | 690 |
| 701 // Remove the first clip child. | 691 // Remove the first clip child. |
| 702 clip_child1->RemoveFromParent(); | 692 clip_child1->RemoveFromParent(); |
| 703 clip_child1 = NULL; | 693 clip_child1 = NULL; |
| 704 | 694 |
| 705 layer_impl_tree_root = | 695 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 706 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 696 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 707 layer_impl_tree_root.Pass(), | 697 host_impl->active_tree()); |
| 708 host_impl->active_tree()); | |
| 709 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 698 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 710 layer_impl_tree_root.get()); | 699 layer_impl_tree_root.get()); |
| 711 ExpectTreesAreIdentical(layer_tree_root.get(), | 700 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 712 layer_impl_tree_root.get(), | 701 layer_impl_tree_root.get(), |
| 713 host_impl->active_tree()); | 702 host_impl->active_tree()); |
| 714 | 703 |
| 715 // Add an additional clip child. | 704 // Add an additional clip child. |
| 716 scoped_refptr<Layer> additional_clip_child = Layer::Create(layer_settings_); | 705 scoped_refptr<Layer> additional_clip_child = Layer::Create(layer_settings_); |
| 717 intervening->AddChild(additional_clip_child); | 706 intervening->AddChild(additional_clip_child); |
| 718 additional_clip_child->SetClipParent(clip_parent.get()); | 707 additional_clip_child->SetClipParent(clip_parent.get()); |
| 719 layer_impl_tree_root = | 708 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 720 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 709 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 721 layer_impl_tree_root.Pass(), | 710 host_impl->active_tree()); |
| 722 host_impl->active_tree()); | |
| 723 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 711 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 724 layer_impl_tree_root.get()); | 712 layer_impl_tree_root.get()); |
| 725 ExpectTreesAreIdentical(layer_tree_root.get(), | 713 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 726 layer_impl_tree_root.get(), | 714 layer_impl_tree_root.get(), |
| 727 host_impl->active_tree()); | 715 host_impl->active_tree()); |
| 728 | 716 |
| 729 // Remove the nearest clipping ancestor. | 717 // Remove the nearest clipping ancestor. |
| 730 clip_parent->RemoveFromParent(); | 718 clip_parent->RemoveFromParent(); |
| 731 clip_parent = NULL; | 719 clip_parent = NULL; |
| 732 layer_impl_tree_root = | 720 layer_impl_tree_root = TreeSynchronizer::SynchronizeTrees( |
| 733 TreeSynchronizer::SynchronizeTrees(layer_tree_root.get(), | 721 layer_tree_root.get(), std::move(layer_impl_tree_root), |
| 734 layer_impl_tree_root.Pass(), | 722 host_impl->active_tree()); |
| 735 host_impl->active_tree()); | |
| 736 TreeSynchronizer::PushProperties(layer_tree_root.get(), | 723 TreeSynchronizer::PushProperties(layer_tree_root.get(), |
| 737 layer_impl_tree_root.get()); | 724 layer_impl_tree_root.get()); |
| 738 ExpectTreesAreIdentical(layer_tree_root.get(), | 725 ExpectTreesAreIdentical(layer_tree_root.get(), |
| 739 layer_impl_tree_root.get(), | 726 layer_impl_tree_root.get(), |
| 740 host_impl->active_tree()); | 727 host_impl->active_tree()); |
| 741 | 728 |
| 742 // The clip children should have been unhooked. | 729 // The clip children should have been unhooked. |
| 743 EXPECT_EQ(2u, intervening->children().size()); | 730 EXPECT_EQ(2u, intervening->children().size()); |
| 744 EXPECT_FALSE(clip_child2->clip_parent()); | 731 EXPECT_FALSE(clip_child2->clip_parent()); |
| 745 EXPECT_FALSE(additional_clip_child->clip_parent()); | 732 EXPECT_FALSE(additional_clip_child->clip_parent()); |
| 746 } | 733 } |
| 747 | 734 |
| 748 } // namespace | 735 } // namespace |
| 749 } // namespace cc | 736 } // namespace cc |
| OLD | NEW |