QUIC - Code to verify SCT tag with certificate transparency verifier

net/quic/crypto/proof_verifier_chromium_test.cc

Index: net/quic/crypto/proof_verifier_chromium_test.cc
diff --git a/net/quic/crypto/proof_verifier_chromium_test.cc b/net/quic/crypto/proof_verifier_chromium_test.cc
index 9a7f0db86ff96bae69ab8436dc63e32781f70b0f..038756859699edbac6d259a4893281eb898ddb71 100644
--- a/net/quic/crypto/proof_verifier_chromium_test.cc
+++ b/net/quic/crypto/proof_verifier_chromium_test.cc
@@ -149,7 +149,8 @@ const char kTestConfig[] = "server config bytes";
 // verification fails.
 TEST(ProofVerifierChromiumTest, FailsIfCertFails) {

[Eran Messeri, 2015/11/18 11:14:00]

Should there be another test case with non-null CTVerifier to make sure what it
returns get stored in the ProofVerifyDetails?

[Ryan Hamilton, 2015/11/18 20:57:26]

Agreed.

[ramant (doing other things), 2015/11/21 00:27:03]

Good point. Added tests.
Done.

   MockCertVerifier dummy_verifier;
-  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
@@ -171,7 +172,8 @@ TEST(ProofVerifierChromiumTest, FailsIfCertFails) {
 // signature fails.
 TEST(ProofVerifierChromiumTest, FailsIfSignatureFails) {
   FailsTestCertVerifier cert_verifier;
-  ProofVerifierChromium proof_verifier(&cert_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&cert_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
@@ -202,7 +204,8 @@ TEST(ProofVerifierChromiumTest, PreservesEVIfNoPolicy) {
   MockCertVerifier dummy_verifier;
   dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
 
-  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
@@ -242,7 +245,7 @@ TEST(ProofVerifierChromiumTest, PreservesEVIfAllowed) {
   MockCertPolicyEnforcer policy_enforcer(true /*is_ev*/);
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
@@ -282,7 +285,7 @@ TEST(ProofVerifierChromiumTest, StripsEVIfNotAllowed) {
   MockCertPolicyEnforcer policy_enforcer(false /*is_ev*/);
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
@@ -323,7 +326,7 @@ TEST(ProofVerifierChromiumTest, IgnoresPolicyEnforcerIfNotEV) {
   FailsTestCertPolicyEnforcer policy_enforcer;
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));