QUIC - Code to verify SCT tag with certificate transparency verifier

net/quic/crypto/proof_verifier_chromium_test.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/crypto/proof_verifier_chromium.h"
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "net/base/net_errors.h"
 #include "net/base/test_data_directory.h"
@@ skipping 129 matching lines @@
                      sizeof(kTestSignature));
 }
 
 const char kTestHostname[] = "test.example.com";
 const char kTestConfig[] = "server config bytes";
 
 }  // namespace
 
 // Tests that the ProofVerifier fails verification if certificate
 // verification fails.
 TEST(ProofVerifierChromiumTest, FailsIfCertFails) {

[Eran Messeri, 2015/11/18 11:14:00]

Should there be another test case with non-null CTVerifier to make sure what it
returns get stored in the ProofVerifyDetails?

[Ryan Hamilton, 2015/11/18 20:57:26]

Agreed.

[ramant (doing other things), 2015/11/21 00:27:03]

Good point. Added tests.
Done.

   MockCertVerifier dummy_verifier;
-  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
   QuicAsyncStatus status = proof_verifier.VerifyProof(
       kTestHostname, kTestConfig, certs, "", GetTestSignature(),
       verify_context.get(), &error_details, &details, callback);
   ASSERT_EQ(QUIC_FAILURE, status);
   delete callback;
 }
 
 // Tests that the ProofVerifier doesn't verify certificates if the config
 // signature fails.
 TEST(ProofVerifierChromiumTest, FailsIfSignatureFails) {
   FailsTestCertVerifier cert_verifier;
-  ProofVerifierChromium proof_verifier(&cert_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&cert_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
@@ skipping 10 matching lines @@
   scoped_refptr<X509Certificate> test_cert = GetTestServerCertificate();
   ASSERT_TRUE(test_cert);
 
   CertVerifyResult dummy_result;
   dummy_result.verified_cert = test_cert;
   dummy_result.cert_status = CERT_STATUS_IS_EV;
 
   MockCertVerifier dummy_verifier;
   dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
 
-  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr);
+  ProofVerifierChromium proof_verifier(&dummy_verifier, nullptr, nullptr,
+                                       nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
@@ skipping 19 matching lines @@
   CertVerifyResult dummy_result;
   dummy_result.verified_cert = test_cert;
   dummy_result.cert_status = CERT_STATUS_IS_EV;
 
   MockCertVerifier dummy_verifier;
   dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
 
   MockCertPolicyEnforcer policy_enforcer(true /*is_ev*/);
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
@@ skipping 19 matching lines @@
   CertVerifyResult dummy_result;
   dummy_result.verified_cert = test_cert;
   dummy_result.cert_status = CERT_STATUS_IS_EV;
 
   MockCertVerifier dummy_verifier;
   dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
 
   MockCertPolicyEnforcer policy_enforcer(false /*is_ev*/);
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
@@ skipping 20 matching lines @@
   CertVerifyResult dummy_result;
   dummy_result.verified_cert = test_cert;
   dummy_result.cert_status = 0;
 
   MockCertVerifier dummy_verifier;
   dummy_verifier.AddResultForCert(test_cert.get(), dummy_result, OK);
 
   FailsTestCertPolicyEnforcer policy_enforcer;
 
   ProofVerifierChromium proof_verifier(&dummy_verifier, &policy_enforcer,
-                                       nullptr);
+                                       nullptr, nullptr);
 
   scoped_ptr<ProofVerifyContext> verify_context(
       new ProofVerifyContextChromium(0 /*cert_verify_flags*/, BoundNetLog()));
   scoped_ptr<ProofVerifyDetails> details;
   std::string error_details;
 
   std::vector<std::string> certs;
   ASSERT_NO_FATAL_FAILURE(GetTestCertificates(&certs));
 
   DummyProofVerifierCallback* callback = new DummyProofVerifierCallback;
   QuicAsyncStatus status = proof_verifier.VerifyProof(
       kTestHostname, kTestConfig, certs, "", GetTestSignature(),
       verify_context.get(), &error_details, &details, callback);
   ASSERT_EQ(QUIC_SUCCESS, status);
   delete callback;
 
   ASSERT_TRUE(details.get());
   ProofVerifyDetailsChromium* verify_details =
       static_cast<ProofVerifyDetailsChromium*>(details.get());
   EXPECT_EQ(0u, verify_details->cert_verify_result.cert_status);
 }
 
 }  // namespace test
 }  // namespace net