Bookmark permanent nodes' visibility is embedder's business.

Bookmark permanent nodes' visibility is embedder's business.

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639, 456876
R=noyau@chromium.org,stanisc@chromium.org

Committed: https://crrev.com/6e9afd9d5ef01504534714930188d9d019adc5e7
Cr-Commit-Position: refs/heads/master@{#360443}

[lpromero, 2015-11-18 16:35:33]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 16:36:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454983004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454983004/1

[noyau (Ping after 24h), 2015-11-18 16:49:15]

lgtm

https://codereview.chromium.org/1454983004/diff/1/components/sync_bookmarks/b...
File components/sync_bookmarks/bookmark_model_associator.cc (left):

https://codereview.chromium.org/1454983004/diff/1/components/sync_bookmarks/b...
components/sync_bookmarks/bookmark_model_associator.cc:440: // TODO(stanisc):
crbug.com/456876: consider not doing this on every single
Please add this bug number to the bug description so the bug is tagged when this
lands.

[lpromero, 2015-11-18 17:17:57]

Description was changed from

==========
Bookmark permanent nodes' visibility is embedder's business.

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639
R=noyau@chromium.org
==========

to

==========
Bookmark permanent nodes' visibility is embedder's business.

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639,456876
R=noyau@chromium.org
==========

[lpromero, 2015-11-18 17:18:22]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2015-11-18 17:18:24]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2015-11-18 17:20:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454983004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454983004/1

[lpromero, 2015-11-18 17:30:19]

Description was changed from

==========
Bookmark permanent nodes' visibility is embedder's business.

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639,456876
R=noyau@chromium.org
==========

to

==========
Bookmark permanent nodes' visibility is embedder's business.

This CL removes UpdatePermanentNodeVisibility from bookmarks component code as
it is the embedder's decision to show or not permanent nodes.

BUG=367639,456876
R=noyau@chromium.org,stanisc@chromium.org
==========

[lpromero, 2015-11-18 17:30:20]

lpromero@chromium.org changed reviewers:
+ stanisc@chromium.org

[commit-bot: I haz the power, 2015-11-18 17:30:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 17:30:21]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lpromero, 2015-11-18 17:30:40]

+stanisc as OWNER of this component.

[stanisc, 2015-11-18 21:29:40]

lgtm

[lpromero, 2015-11-18 22:53:48]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2015-11-18 22:55:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454983004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454983004/1

[commit-bot: I haz the power, 2015-11-18 23:20:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-18 23:21:34]

Patchset 1 (id:??) landed as
https://crrev.com/6e9afd9d5ef01504534714930188d9d019adc5e7
Cr-Commit-Position: refs/heads/master@{#360443}