Bookmark permanent nodes' visibility is embedder's business.

components/sync_bookmarks/bookmark_model_associator.cc

Index: components/sync_bookmarks/bookmark_model_associator.cc
diff --git a/components/sync_bookmarks/bookmark_model_associator.cc b/components/sync_bookmarks/bookmark_model_associator.cc
index 27b5824aa705e7306c6ae1f8954cf85c5c87a414..00bf5afaac8b5c2dff1c33cb77643191db17e76c 100644
--- a/components/sync_bookmarks/bookmark_model_associator.cc
+++ b/components/sync_bookmarks/bookmark_model_associator.cc
@@ -371,26 +371,6 @@ BookmarkModelAssociator::~BookmarkModelAssociator() {
   DCHECK(thread_checker_.CalledOnValidThread());
 }
 
-void BookmarkModelAssociator::UpdatePermanentNodeVisibility() {
-  DCHECK(thread_checker_.CalledOnValidThread());
-  DCHECK(bookmark_model_->loaded());
-
-  BookmarkNode::Type bookmark_node_types[] = {
-    BookmarkNode::BOOKMARK_BAR,
-    BookmarkNode::OTHER_NODE,
-    BookmarkNode::MOBILE,
-  };
-  for (size_t i = 0; i < arraysize(bookmark_node_types); ++i) {
-    int64 id = bookmark_model_->PermanentNode(bookmark_node_types[i])->id();
-    bookmark_model_->SetPermanentNodeVisible(
-      bookmark_node_types[i],
-      id_map_.find(id) != id_map_.end());
-  }
-
-  // Note: the root node may have additional extra nodes. Currently their
-  // visibility is not affected by sync.
-}
-
 syncer::SyncError BookmarkModelAssociator::DisassociateModels() {
   id_map_.clear();
   id_map_inverse_.clear();
@@ -437,10 +417,6 @@ void BookmarkModelAssociator::Associate(const BookmarkNode* node,
                                         const syncer::BaseNode& sync_node) {
   AddAssociation(node, sync_node.GetId());
 
-  // TODO(stanisc): crbug.com/456876: consider not doing this on every single

[noyau (Ping after 24h), 2015/11/18 16:49:15]

Please add this bug number to the bug description so the bug is tagged when this
lands.

-  // association.
-  UpdatePermanentNodeVisibility();
-
   // The same check exists in PersistAssociations. However it is better to
   // do the check earlier to avoid the cost of decrypting nodes again
   // in PersistAssociations.