Source/core/rendering/svg/RenderSVGTSpan.cpp - Issue 145493012: <br> nodes should not be allowed within SVG text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGTSpan.cpp

Issue 145493012: <br> nodes should not be allowed within SVG text (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reupload ps#3. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGTSpan.cpp

diff --git a/Source/core/rendering/svg/RenderSVGTSpan.cpp b/Source/core/rendering/svg/RenderSVGTSpan.cpp

index 168037e97903a0b97f8e5d8a25fa80c7fd6b1b4a..9c71d5416842354b83b58a94ec31ffd235424ab2 100644

--- a/Source/core/rendering/svg/RenderSVGTSpan.cpp

+++ b/Source/core/rendering/svg/RenderSVGTSpan.cpp

@@ -36,9 +36,9 @@ RenderSVGTSpan::RenderSVGTSpan(Element* element)

bool RenderSVGTSpan::isChildAllowed(RenderObject* child, RenderStyle*) const

{

- // Always allow text (except empty textnodes).

+ // Always allow text (except empty textnodes and <br>).

if (child->isText())

- return !SVGRenderSupport::isEmptySVGInlineText(child);

+ return SVGRenderSupport::isRenderableTextNode(child);

#if ENABLE(SVG_FONTS)

// Only allow other types of children if this is not an 'altGlyph'.