Source/core/rendering/svg/RenderSVGInline.cpp - Issue 145493012: <br> nodes should not be allowed within SVG text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGInline.cpp

Issue 145493012: <br> nodes should not be allowed within SVG text (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reupload ps#3. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGInline.cpp

diff --git a/Source/core/rendering/svg/RenderSVGInline.cpp b/Source/core/rendering/svg/RenderSVGInline.cpp

index 51d884076255eb29491d563b09d896bdf9befaf1..64f6b4d66accd8193cc09e9e46557f9f35ff74c9 100644

--- a/Source/core/rendering/svg/RenderSVGInline.cpp

+++ b/Source/core/rendering/svg/RenderSVGInline.cpp

@@ -33,8 +33,8 @@ namespace WebCore {

bool RenderSVGInline::isChildAllowed(RenderObject* child, RenderStyle* style) const

{

- if (SVGRenderSupport::isEmptySVGInlineText(child))

- return false;

+ if (child->isText())

+ return SVGRenderSupport::isRenderableTextNode(child);

if (node()->hasTagName(SVGNames::aTag)) {

// Disallow direct descendant 'a'.