Change Views menus to consistently use GetNativeTheme for theming.

Change Views menus to consistently use GetNativeTheme for theming.

Prior to this patch, the menus used a mixture of GetNativeTheme() for most
colors (except the border color) and a passed-in NativeTheme for menu
configs (padding, etc.). This consolidates to the former.

crrev.com/563454636cfe3df6a57 broke menus because the passed-in NativeTheme
was of the NativeThemeDark* variety, and MenuConfig depends on whether it
matches various NativeTheme::instance() instances.

BUG=501377, 415953
Committed: https://crrev.com/99eaa0d2b320691b295ac7d5ab27aae4896a9cba
Cr-Commit-Position: refs/heads/master@{#360168}

[Evan Stade, 2015-11-17 02:33:20]

Description was changed from

==========
Change Views menus to consistently use GetNativeTheme for theming.

Prior to this patch, the menus used a mixture of GetNativeTheme() for most
colors (except the border color) and a passed-in NativeTheme for menu
configs (padding, etc.). This consolidates to the former.

crrev.com/563454636cfe3df6a57 broke menus because the passed-in NativeTheme
was of the NativeThemeDark* variety, and MenuConfig depends on whether it
matches various NativeTheme::instance() instances.

BUG=501377
==========

to

==========
Change Views menus to consistently use GetNativeTheme for theming.

Prior to this patch, the menus used a mixture of GetNativeTheme() for most
colors (except the border color) and a passed-in NativeTheme for menu
configs (padding, etc.). This consolidates to the former.

crrev.com/563454636cfe3df6a57 broke menus because the passed-in NativeTheme
was of the NativeThemeDark* variety, and MenuConfig depends on whether it
matches various NativeTheme::instance() instances.

BUG=501377,415953
==========

[Evan Stade, 2015-11-17 02:33:20]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-11-17 02:35:22]

I don't think this fixes crbug.com/415953 but it's certainly related. It should
fix the problems introduced by my last patch.

[Evan Stade, 2015-11-17 02:35:28]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 02:36:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454583002/40001

[commit-bot: I haz the power, 2015-11-17 02:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 02:47:12]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[sky, 2015-11-17 18:22:24]

https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:1734: static MenuConfig* menu_config =
nullptr;
I don't like the static here. Can you get the menuconfig from the root item?

[Evan Stade, 2015-11-17 18:54:33]

https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_controller.cc (right):

https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
ui/views/controls/menu/menu_controller.cc:1734: static MenuConfig* menu_config =
nullptr;
On 2015/11/17 18:22:24, sky wrote:
> I don't like the static here. Can you get the menuconfig from the root item?

I'm not sure what you meant by root item, but I think I found a way to reliably
get a relevant MenuItemView.

[Evan Stade, 2015-11-17 18:54:46]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-17 18:57:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454583002/60001

[commit-bot: I haz the power, 2015-11-17 19:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-17 19:41:36]

Dry run: This issue passed the CQ dry run.

[sky, 2015-11-17 21:21:16]

On 2015/11/17 18:54:33, Evan Stade wrote:
>
https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
> File ui/views/controls/menu/menu_controller.cc (right):
> 
>
https://codereview.chromium.org/1454583002/diff/40001/ui/views/controls/menu/...
> ui/views/controls/menu/menu_controller.cc:1734: static MenuConfig* menu_config
=
> nullptr;
> On 2015/11/17 18:22:24, sky wrote:
> > I don't like the static here. Can you get the menuconfig from the root item?
> 
> I'm not sure what you meant by root item, but I think I found a way to
reliably
> get a relevant MenuItemView.

https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/controls/...

LGTM

[Evan Stade, 2015-11-17 21:35:36]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-11-17 21:35:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454583002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454583002/60001

[commit-bot: I haz the power, 2015-11-17 21:40:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-17 21:41:31]

Patchset 4 (id:??) landed as
https://crrev.com/99eaa0d2b320691b295ac7d5ab27aae4896a9cba
Cr-Commit-Position: refs/heads/master@{#360168}