Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: ui/views/controls/menu/menu_separator_win.cc

Issue 1454583002: Change Views menus to consistently use GetNativeTheme for theming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: get menu config from item Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/controls/menu/menu_scroll_view_container.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/controls/menu/menu_separator.h" 5 #include "ui/views/controls/menu/menu_separator.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <uxtheme.h> 8 #include <uxtheme.h>
9 #include <Vssym32.h> 9 #include <Vssym32.h>
10 10
11 #include "ui/gfx/canvas.h" 11 #include "ui/gfx/canvas.h"
12 #include "ui/gfx/geometry/rect.h" 12 #include "ui/gfx/geometry/rect.h"
13 #include "ui/gfx/win/dpi.h" 13 #include "ui/gfx/win/dpi.h"
14 #include "ui/native_theme/native_theme.h" 14 #include "ui/native_theme/native_theme.h"
15 #include "ui/native_theme/native_theme_aura.h" 15 #include "ui/native_theme/native_theme_aura.h"
16 #include "ui/views/controls/menu/menu_config.h"
17 #include "ui/views/controls/menu/menu_item_view.h" 16 #include "ui/views/controls/menu/menu_item_view.h"
18 17
19 namespace views { 18 namespace views {
20 19
21 void MenuSeparator::OnPaint(gfx::Canvas* canvas) { 20 void MenuSeparator::OnPaint(gfx::Canvas* canvas) {
22 const MenuConfig& config = parent_menu_item_->GetMenuConfig(); 21 ui::NativeTheme* native_theme = GetNativeTheme();
23 22 if (native_theme == ui::NativeThemeAura::instance()) {
24 if (config.native_theme == ui::NativeThemeAura::instance()) {
25 OnPaintAura(canvas); 23 OnPaintAura(canvas);
26 return; 24 return;
27 } 25 }
28 26
29 gfx::Rect separator_bounds = GetPaintBounds(); 27 gfx::Rect separator_bounds = GetPaintBounds();
30 28
31
32 // Hack to get the separator to display correctly on Windows where we may 29 // Hack to get the separator to display correctly on Windows where we may
33 // have fractional scales. We move the separator 1 pixel down to ensure that 30 // have fractional scales. We move the separator 1 pixel down to ensure that
34 // it falls within the clipping rect which is scaled up. 31 // it falls within the clipping rect which is scaled up.
35 float device_scale = gfx::GetDPIScale(); 32 float device_scale = gfx::GetDPIScale();
36 bool is_fractional_scale = 33 bool is_fractional_scale =
37 (device_scale - static_cast<int>(device_scale) != 0); 34 (device_scale - static_cast<int>(device_scale) != 0);
38 if (is_fractional_scale && separator_bounds.y() == 0) 35 if (is_fractional_scale && separator_bounds.y() == 0)
39 separator_bounds.set_y(1); 36 separator_bounds.set_y(1);
40 37
41 ui::NativeTheme::ExtraParams extra; 38 ui::NativeTheme::ExtraParams extra;
42 config.native_theme->Paint( 39 native_theme->Paint(
43 canvas->sk_canvas(), ui::NativeTheme::kMenuPopupSeparator, 40 canvas->sk_canvas(), ui::NativeTheme::kMenuPopupSeparator,
44 ui::NativeTheme::kNormal, separator_bounds, extra); 41 ui::NativeTheme::kNormal, separator_bounds, extra);
45 } 42 }
46 43
47 } // namespace views 44 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/controls/menu/menu_scroll_view_container.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698