Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 145443005: Fixes for memory and threading issues in cast (Closed)

Created:
6 years, 11 months ago by Alpha Left Google
Modified:
6 years, 11 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Fixes for memory and threading issues in cast This change fixes one issue in media/cast code. TickClock is not owned by CastEnvironment TickClock assigned to CastEnvironment is owned by the creator of CastSender/CastReceiver. However CastEnvironment is ref-counted. This means it is possible that TickClock is deleted but deferenced by some objects that still uses CastEnvironment. Fixing this requires a sweeping change in unit tests. And it also affects End2End test. The result is that CastEnvironment is shared between CastSender and CastReceiver. This adds requirements to log filtering because now a CastEnvironment used by CastSender can see receiver events. Tested this patch with valgrind and cast_unittests reports no error. BUG=336887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246863

Patch Set 1 #

Patch Set 2 : upload again #

Patch Set 3 : #

Patch Set 4 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -162 lines) Patch
M chrome/renderer/media/cast_session_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/audio_receiver/audio_decoder_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M media/cast/audio_receiver/audio_receiver_unittest.cc View 7 chunks +16 lines, -11 lines 0 comments Download
M media/cast/audio_sender/audio_encoder_unittest.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M media/cast/cast_environment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/cast_environment.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 2 chunks +31 lines, -29 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M media/cast/rtcp/rtcp_unittest.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M media/cast/test/encode_decode_test.cc View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 23 chunks +34 lines, -39 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/test/sender.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M media/cast/video_receiver/video_decoder_unittest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M media/cast/video_receiver/video_receiver.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M media/cast/video_receiver/video_receiver_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M media/cast/video_sender/external_video_encoder_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/video_sender/video_encoder_impl_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alpha Left Google
6 years, 11 months ago (2014-01-24 00:32:03 UTC) #1
mikhal1
lgtm
6 years, 11 months ago (2014-01-24 00:39:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/145443005/80001
6 years, 11 months ago (2014-01-24 00:41:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=215668
6 years, 11 months ago (2014-01-24 01:10:56 UTC) #4
Alpha Left Google
+scherkus for chrome/renderer/media.
6 years, 11 months ago (2014-01-24 01:36:05 UTC) #5
scherkus (not reviewing)
lgtm
6 years, 11 months ago (2014-01-24 01:41:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/145443005/530001
6 years, 11 months ago (2014-01-24 01:44:01 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=215717
6 years, 11 months ago (2014-01-24 02:05:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/145443005/680001
6 years, 11 months ago (2014-01-24 02:08:55 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-24 13:09:10 UTC) #10
Message was sent while issue was closed.
Change committed as 246863

Powered by Google App Engine
This is Rietveld 408576698