Fixes for memory and threading issues in cast

media/cast/video_sender/video_sender.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/cast/video_sender/video_sender.h"
 
 #include <list>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 167 matching lines @@
 }
 
 void VideoSender::SendRtcpReport() {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::MAIN));
 
   transport::RtcpSenderLogMessage sender_log_message;
   VideoRtcpRawMap video_logs =
       cast_environment_->Logging()->GetVideoRtcpRawData();
 
   while (!video_logs.empty()) {
+    // TODO(hclam): Avoid calling begin() within a loop.
     VideoRtcpRawMap::iterator it = video_logs.begin();
     uint32 rtp_timestamp = it->first;
 
     transport::RtcpSenderFrameLogMessage frame_message;
     frame_message.rtp_timestamp = rtp_timestamp;
     frame_message.frame_status = transport::kRtcpSenderFrameStatusUnknown;
+    bool ignore_event = false;
 
     switch (it->second.type) {
       case kVideoFrameCaptured:
         frame_message.frame_status =
             transport::kRtcpSenderFrameStatusDroppedByFlowControl;
         break;
       case kVideoFrameSentToEncoder:
         frame_message.frame_status =
             transport::kRtcpSenderFrameStatusDroppedByEncoder;
         break;
       case kVideoFrameEncoded:
         frame_message.frame_status =
             transport::kRtcpSenderFrameStatusSentToNetwork;
         break;
       default:
-        NOTREACHED();
-        break;
+        ignore_event = true;
     }
     video_logs.erase(rtp_timestamp);
-    sender_log_message.push_back(frame_message);
+    if (!ignore_event)
+      sender_log_message.push_back(frame_message);
   }
 
   rtcp_->SendRtcpFromRtpSender(sender_log_message);
   if (!sender_log_message.empty()) {
     VLOG(1) << "Failed to send all log messages";
   }
   ScheduleNextRtcpReport();
 }
 
 void VideoSender::ScheduleNextResendCheck() {
@@ skipping 178 matching lines @@
 
 void VideoSender::ResendPacketsOnTransportThread(
     const transport::MissingFramesAndPacketsMap& missing_packets) {
   DCHECK(cast_environment_->CurrentlyOn(CastEnvironment::TRANSPORT));
   last_send_time_ = cast_environment_->Clock()->NowTicks();
   transport_sender_->ResendPackets(false, missing_packets);
 }
 
 }  // namespace cast
 }  // namespace media