SkFontConfigInterface::createTypeface()

SkFontConfigInterface::createTypeface()

BUG=524578
R=bungeman@google.com,reed@google.com

Committed: https://skia.googlesource.com/skia/+/9b137dc54e668ca5552bab8a1c550edc02214db4

[bungeman-skia, 2015-11-20 15:13:33]

lgtm

[reed1, 2015-11-20 15:30:14]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-11-20 15:30:14]

https://codereview.chromium.org/1454343003/diff/1/include/ports/SkFontConfigI...
File include/ports/SkFontConfigInterface.h (right):

https://codereview.chromium.org/1454343003/diff/1/include/ports/SkFontConfigI...
include/ports/SkFontConfigInterface.h:103: virtual SkTypeface* getTypeface(const
FontIdentity& identity) {
We usually use get... to return a non-ownership-transfered value, and
new/create/alloc/ref... to mean the caller must take some ownership action.

[f(malita), 2015-11-20 15:42:26]

Description was changed from

==========
SkFontConfigInterface::getTypeface()

BUG=524578
R=bungeman@google.com
==========

to

==========
SkFontConfigInterface::createTypeface()

BUG=524578
R=bungeman@google.com,reed@google.com
==========

[f(malita), 2015-11-20 15:43:00]

https://codereview.chromium.org/1454343003/diff/1/include/ports/SkFontConfigI...
File include/ports/SkFontConfigInterface.h (right):

https://codereview.chromium.org/1454343003/diff/1/include/ports/SkFontConfigI...
include/ports/SkFontConfigInterface.h:103: virtual SkTypeface* getTypeface(const
FontIdentity& identity) {
On 2015/11/20 15:30:14, reed1 wrote:
> We usually use get... to return a non-ownership-transfered value, and
> new/create/alloc/ref... to mean the caller must take some ownership action. 

Done.

(renamed to createTypeface)

[f(malita), 2015-11-20 15:43:05]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-20 15:43:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454343003/20001

[f(malita), 2015-11-20 17:09:30]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2015-11-20 17:14:16]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-11-20 17:14:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1454343003/#ps20001
(title: "rename to createTypeface")

[commit-bot: I haz the power, 2015-11-20 17:14:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454343003/20001

[commit-bot: I haz the power, 2015-11-20 17:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-20 17:15:26]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[reed1, 2015-11-20 17:30:58]

lgtm

[reed1, 2015-11-20 17:31:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-11-20 17:31:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1454343003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1454343003/20001

[commit-bot: I haz the power, 2015-11-20 21:47:57]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9b137dc54e668ca5552bab8a1c550edc02214db4