SkFontConfigInterface::createTypeface()

include/ports/SkFontConfigInterface.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef SkFontConfigInterface_DEFINED
 #define SkFontConfigInterface_DEFINED
 
@@ skipping 77 matching lines @@
                                  SkTypeface::Style* outStyle) = 0;
 
     /**
      *  Given a FontRef, open a stream to access its data, or return null
      *  if the FontRef's data is not available. The caller is responsible for
      *  deleting the stream when it is done accessing the data.
      */
     virtual SkStreamAsset* openStream(const FontIdentity&) = 0;
 
     /**
+     *  Return an SkTypeface for the given FontIdentity.
+     *
+     *  The default implementation simply returns a new typeface built using data obtained from
+     *  openStream(), but derived classes may implement more complex caching schemes.
+     */
+    virtual SkTypeface* getTypeface(const FontIdentity& identity) {

[reed1, 2015/11/20 15:30:14]

We usually use get... to return a non-ownership-transfered value, and
new/create/alloc/ref... to mean the caller must take some ownership action. 

[f(malita), 2015/11/20 15:43:00]

Done.

(renamed to createTypeface)

+        return SkTypeface::CreateFromStream(this->openStream(identity), identity.fTTCIndex);
+    }
+
+    /**
      *  Return a singleton instance of a direct subclass that calls into
      *  libfontconfig. This does not affect the refcnt of the returned instance.
      *  The mutex may be used to guarantee the singleton is only constructed once.
      */
     static SkFontConfigInterface* GetSingletonDirectInterface(SkBaseMutex* mutex = NULL);
 
     // New APIS, which have default impls for now (which do nothing)
 
     virtual SkDataTable* getFamilyNames() { return SkDataTable::NewEmpty(); }
     virtual bool matchFamilySet(const char[] /*inFamilyName*/,
                                 SkString* /*outFamilyName*/,
                                 SkTArray<FontIdentity>*) {
         return false;
     }
     typedef SkRefCnt INHERITED;
 };
 
 #endif