Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1453743002: Add an upload presubmit rule to catch disallowed use of Chromium namespaces. (Closed)

Created:
5 years, 1 month ago by jbroman
Modified:
5 years, 1 month ago
Reviewers:
Dirk Pranke, esprehn
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an upload presubmit rule to catch disallowed use of Chromium namespaces. These namespaces and classes may soon be linked into Blink's core (via platform and/or WTF), but they are not intended to be used within Blink's engine. This rule should catch most inadvertent cases of this, and #include is already checked by check-blink-deps. TESTED=manually Committed: https://crrev.com/bcc0d06fbc3bf08d416c7143056d26a4a418b00b Cr-Commit-Position: refs/heads/master@{#360165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 2 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbroman
If this satisfies you as far as automated checks for Chromium use outside of the ...
5 years, 1 month ago (2015-11-17 17:56:16 UTC) #2
esprehn
lgtm
5 years, 1 month ago (2015-11-17 21:12:11 UTC) #3
jbroman
+dpranke for PRESUBMIT.py OWNERS
5 years, 1 month ago (2015-11-17 21:13:08 UTC) #5
Dirk Pranke
lgtm
5 years, 1 month ago (2015-11-17 21:23:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1453743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1453743002/1
5 years, 1 month ago (2015-11-17 21:27:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 21:32:42 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 21:33:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc0d06fbc3bf08d416c7143056d26a4a418b00b
Cr-Commit-Position: refs/heads/master@{#360165}

Powered by Google App Engine
This is Rietveld 408576698