Add an upload presubmit rule to catch disallowed use of Chromium namespaces.

third_party/WebKit/PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 207 matching lines @@
 
     for f in input_api.AffectedFiles():
         if not f.LocalPath().endswith('-expected.txt'):
             continue
         for line_num, line in f.ChangedContents():
             error = pattern.search(line)
             if error:
                 results.append(output_api.PresubmitError('Found an invalid preference %s in expected result %s:%s' % (error.group(1), f, line_num)))
     return results
 
+
+def _CheckForForbiddenNamespace(input_api, output_api):
+    """Checks that Blink uses Chromium namespaces only in permitted code."""
+    # This list is not exhaustive, but covers likely ones.
+    chromium_namespaces = ["base", "cc", "content", "gfx", "net", "ui"]
+    chromium_classes = ["scoped_ptr", "scoped_refptr"]
+
+    def source_file_filter(path):
+        return input_api.FilterSourceFile(path,
+                                          white_list=[r'third_party/WebKit/Source/.*\.(h|cpp)$'],
+                                          black_list=[r'third_party/WebKit/Source/(platform|wtf|web)/'])
+
+    comment_re = input_api.re.compile(r'^\s*//')
+    result = []
+    for namespace in chromium_namespaces:
+        namespace_re = input_api.re.compile(r'\b{0}::|^\s*using namespace {0};|^\s*namespace {0} \{{'.format(input_api.re.escape(namespace)))
+        uses_namespace_outside_comments = lambda line: namespace_re.search(line) and not comment_re.search(line)
+        errors = input_api.canned_checks._FindNewViolationsOfRule(lambda _, line: not uses_namespace_outside_comments(line),
+                                                                  input_api, source_file_filter)
+        if errors:
+            result += [output_api.PresubmitError('Do not use Chromium namespace {} inside Blink core:\n{}'.format(namespace, '\n'.join(errors)))]
+    for class_name in chromium_classes:
+        class_re = input_api.re.compile(r'\b{0}\b'.format(input_api.re.escape(class_name)))
+        uses_class_outside_comments = lambda line: class_re.search(line) and not comment_re.search(line)
+        errors = input_api.canned_checks._FindNewViolationsOfRule(lambda _, line: not uses_class_outside_comments(line),
+                                                                  input_api, source_file_filter)
+        if errors:
+            result += [output_api.PresubmitError('Do not use Chromium class {} inside Blink core:\n{}'.format(class_name, '\n'.join(errors)))]
+    return result
+
+
 def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(_CheckStyle(input_api, output_api))
     results.extend(_CheckForPrintfDebugging(input_api, output_api))
     results.extend(_CheckForDangerousTestFunctions(input_api, output_api))
     results.extend(_CheckForInvalidPreferenceError(input_api, output_api))
+    results.extend(_CheckForForbiddenNamespace(input_api, output_api))
     return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(input_api.canned_checks.CheckTreeIsOpen(
         input_api, output_api,
         json_url='http://chromium-status.appspot.com/current?format=json'))
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
@@ skipping 19 matching lines @@
     for master in masters:
         try_config.setdefault(master, {})
         for builder in masters[master]:
             # Do not trigger presubmit builders, since they're likely to fail
             # (e.g. OWNERS checks before finished code review), and we're
             # running local presubmit anyway.
             if 'presubmit' not in builder:
                 try_config[master][builder] = ['defaulttests']
 
     return try_config