Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 145363002: Eclipse generator now uses compiler's default include dirs. (Closed)

Created:
6 years, 11 months ago by newt (away)
Modified:
6 years, 11 months ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Eclipse generator now uses compiler's default include dirs. This adds support to the Eclipse gyp generator for detecting the compiler's default include directories and adding them to the list of include dirs. This finally fixes a long-standing bug where size_t was not defined in the Android Eclipse setup. BUG=336982

Patch Set 1 #

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -14 lines) Patch
M pylib/gyp/generator/eclipse.py View 1 8 chunks +41 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
newt (away)
PTAL, thanks!
6 years, 11 months ago (2014-01-22 23:32:33 UTC) #1
Nico
lgtm
6 years, 11 months ago (2014-01-22 23:39:27 UTC) #2
newt (away)
Thanks. I believe you have to land this for me?
6 years, 11 months ago (2014-01-22 23:53:35 UTC) #3
newt (away)
6 years, 11 months ago (2014-01-27 23:15:56 UTC) #4
Committed as r1844

Powered by Google App Engine
This is Rietveld 408576698